From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Date: Tue, 02 Jul 2013 14:58:06 +0200 Subject: [U-Boot] [PATCH v2] cmd_bootm.c: Correct BOOTM_ERR_OVERLAP handling In-Reply-To: <51D2C901.8000805@ti.com> References: <1372443665-9584-1-git-send-email-trini@ti.com> <1372451133-30779-1-git-send-email-trini@ti.com> <51D2B04F.5090003@gmail.com> <51D2C901.8000805@ti.com> Message-ID: <51D2CE5E.3050802@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/02/2013 02:35 PM, Tom Rini wrote: > On 07/02/2013 06:49 AM, Andreas Bie?mann wrote: >> Hi all, > >> On 06/28/2013 11:41 PM, Simon Glass wrote: >>> Hi Tom, >>> >>> On Fri, Jun 28, 2013 at 1:25 PM, Tom Rini wrote: > >> > >>>> @@ -660,34 +680,25 @@ static int do_bootm_states(cmd_tbl_t >>>> *cmdtp, int flag, int argc, } #endif /* Now run the OS! We hope >>>> this doesn't return */ - if (!ret && (states & >>>> BOOTM_STATE_OS_GO)) + if (!ret && (states & >>>> BOOTM_STATE_OS_GO)) { ret = boot_selected_os(argc, argv, >>>> BOOTM_STATE_OS_GO, images, boot_fn, &iflag); + if >>>> (ret) + goto err; + } + + >>>> return ret; >>>> >>> >>> Thanks for getting to the bottom of this. >>> >>> Just a question here - should this fall through to display the >>> error with the code below? For example if the subcommand is not >>> supported... > >> as pointed out by Simon the error message 'subcommand not >> supported' disappears with this patch. >> Who will fix that? I'll have a look for the avr32 specific part. > > The patch I posted yesterday should fix that. Oups, overseen, you mean http://patchwork.ozlabs.org/patch/256125/ right? Best regards Andreas Bie?mann