From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cramfs: fix bug for wrong filename comparison
Date: Mon, 08 Jul 2013 08:53:54 +0200 [thread overview]
Message-ID: <51DA6202.6050400@keymile.com> (raw)
In-Reply-To: <20130705232321.18999465@lilith>
On 07/05/2013 11:23 PM, Albert ARIBAUD wrote:
> On Thu, 4 Jul 2013 10:29:46 +0200, Holger Brunck
> <holger.brunck@keymile.com> wrote:
>
>> If we have the following entry in cramfs:
>> => cramfsls
>> -rw-r--r-- 1922689 uImage
>>
>> cramfsload would also succeed if we try to do:
>> => cramfsload uImage_1
>> CRAMFS load complete: 1922689 bytes loaded to 0x100000
>>
>> The old code succeeds if the begin of the filename we search matches
>> with a filename stored in cramfs. But the searched file may have
>> additional characters and is therfore not the file we are looking for.
>> So compare also the length of the filename we search and the
>> filename we found in cramfs. This leads to:
>> => cramfsload uImage_1
>> can't find corresponding entry
>> CRAMFS LOAD ERROR<0> for uImage_1!
>>
>> which is the behaviour we want.
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> cc: Wolfgang Denk <wd@denx.de>
>> ---
>
> Can't the commit message above be summarized as follows?
>
> ---8<---
> "cramfsload uImage_1" succeeds even though the actual file is named
> "uImage".
>
> Fix file name comparison when one name is the prefix of the other.
> ---8<---
>
> The demonstrative part of the commit message can go here, below the
> commit message delimiter '---'.
>
ok. I'll send a v2.
Regards
Holger
next prev parent reply other threads:[~2013-07-08 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 8:29 [U-Boot] [PATCH] cramfs: fix bug for wrong filename comparison Holger Brunck
2013-07-05 21:23 ` Albert ARIBAUD
2013-07-08 6:53 ` Holger Brunck [this message]
2013-07-08 7:06 ` [U-Boot] [PATCH v2] " Holger Brunck
2013-07-16 14:37 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DA6202.6050400@keymile.com \
--to=holger.brunck@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox