public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andreas Naumann <dev@andin.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] ARM: omap3: Add option to disable errata workarounds.
Date: Tue, 09 Jul 2013 10:08:10 +0200	[thread overview]
Message-ID: <51DBC4EA.4090104@andin.de> (raw)
In-Reply-To: <1373356832-28983-1-git-send-email-anaumann@ultratronik.de>

Hi,

It seems that all three ARM errata workarounds done in omap3 board-init 
(#454179 #430973 #621766) are solved/not longer needed e.g. in the 
AM/DM37xx chips. Other people have noticed this:
http://e2e.ti.com/support/arm/sitara_arm/f/791/t/254742.aspx

When still applying them (especcially #430973), lots of segmentations 
faults and other strange stuff begin to appear.
So as a simple solution I propose adding a config option to remove these 
workarounds for boards/silicon that dont need them. Is this sensible or 
should there be more automatism?


regards,
Andreas


PS. Does anybody have the "ARM Core Cortex-A8 (AT400/AT401) errata" 
document to make sure my assumption above holds true?



---
  arch/arm/cpu/armv7/omap3/board.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/arm/cpu/armv7/omap3/board.c 
b/arch/arm/cpu/armv7/omap3/board.c
index b72fadc..84045d8 100644
--- a/arch/arm/cpu/armv7/omap3/board.c
+++ b/arch/arm/cpu/armv7/omap3/board.c
@@ -236,8 +236,10 @@ void s_init(void)

  	try_unlock_memory();

+#ifndef CONFIG_SYS_DISABLE_CORTEXA8_ERRATA_WORKAROUNDS
  	/* Errata workarounds */
  	omap3_setup_aux_cr();
+#endif

  #ifndef CONFIG_SYS_L2CACHE_OFF
  	/* Invalidate L2-cache from secure mode */
-- 
1.8.3.1

       reply	other threads:[~2013-07-09  8:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1373356832-28983-1-git-send-email-anaumann@ultratronik.de>
2013-07-09  8:08 ` Andreas Naumann [this message]
2013-07-09  9:10   ` [U-Boot] [RFC] ARM: omap3: Add option to disable errata workarounds Albert ARIBAUD
2013-07-09 10:42     ` Andreas Bießmann
2013-07-09 11:05       ` Albert ARIBAUD
2013-07-09 15:01       ` Andreas Naumann
2013-07-09 15:18         ` Andreas Bießmann
2013-07-09 15:49           ` Peter Meerwald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DBC4EA.4090104@andin.de \
    --to=dev@andin.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox