From: Roger Quadros <rogerq@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] HACK: ehci-omap: do gpio toggle after port power is set
Date: Tue, 9 Jul 2013 12:59:27 +0300 [thread overview]
Message-ID: <51DBDEFF.4030208@ti.com> (raw)
In-Reply-To: <1373317175-28926-4-git-send-email-dmurphy@ti.com>
On 07/08/2013 11:59 PM, Dan Murphy wrote:
> Need to check why gpio toggling in ehci-omap is not
> working and works only from ehci-hcd.
do you mean HSIC detection is not working?
GPIO toggling has to work from anywhere.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/usb/host/ehci-hcd.c | 7 ++++++-
> drivers/usb/host/ehci-omap.c | 2 +-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 706cf0c..17d0c9c 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -29,7 +29,7 @@
> #include <malloc.h>
> #include <watchdog.h>
> #include <linux/compiler.h>
> -
> +#include <asm/ehci-omap.h>
> #include "ehci.h"
>
> #ifndef CONFIG_USB_MAX_CONTROLLER_COUNT
> @@ -776,6 +776,11 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
> if (HCS_PPC(ehci_readl(&ctrl->hccr->cr_hcsparams))) {
> reg |= EHCI_PS_PP;
> ehci_writel(status_reg, reg);
> +#ifdef CONFIG_USB_EHCI_OMAP
> + omap_ehci_phy_reset(1, 1000);
> + mdelay(10);
> + omap_ehci_phy_reset(0, 1000);
> +#endif
Did you try to first keep the PHY in reset, start the EHCI controller
and then release the reset?
At least this is what is done in the Linux kernel to get it to work.
> }
> break;
> case USB_PORT_FEAT_RESET:
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 17f2214..68add44 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
> @@ -109,7 +109,7 @@ int board_usb_init(void) __attribute__((weak, alias("__board_usb_init")));
> #if defined(CONFIG_OMAP_EHCI_PHY1_RESET_GPIO) || \
> defined(CONFIG_OMAP_EHCI_PHY2_RESET_GPIO)
> /* controls PHY(s) reset signal(s) */
> -static inline void omap_ehci_phy_reset(int on, int delay)
> +void omap_ehci_phy_reset(int on, int delay)
> {
> /*
> * Refer ISSUE1:
>
cheers,
-roger
next prev parent reply other threads:[~2013-07-09 9:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 20:59 [U-Boot] [PATCH] OMAP5: USB_EHCI: Enable ehci support for omap5 Dan Murphy
2013-07-08 20:59 ` [U-Boot] [PATCH 1/3] omap5: uevm: Change the board name to correct name Dan Murphy
2013-07-08 20:59 ` [U-Boot] [PATCH 2/3] usb: omap5-evm: Add ethernet support to the uevm Dan Murphy
2013-07-08 21:13 ` Nishanth Menon
2013-07-09 3:29 ` Lokesh Vutla
2013-07-09 9:57 ` Roger Quadros
2013-07-08 20:59 ` [U-Boot] [PATCH 3/3] HACK: ehci-omap: do gpio toggle after port power is set Dan Murphy
2013-07-09 9:59 ` Roger Quadros [this message]
2013-07-10 18:47 ` Dan Murphy
2013-07-09 3:21 ` [U-Boot] [PATCH] OMAP5: USB_EHCI: Enable ehci support for omap5 Lokesh Vutla
2013-07-10 15:02 ` Dan Murphy
2013-07-10 15:03 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DBDEFF.4030208@ti.com \
--to=rogerq@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox