From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 10 Jul 2013 09:38:06 -0600 Subject: [U-Boot] [PATCH 1/2] cmd_bootm.c: Make bootz consume 'bootz' from argv, decrement argc In-Reply-To: References: <1373398497-4658-1-git-send-email-trini@ti.com> <51DCEA16.8050106@wwwdotorg.org> Message-ID: <51DD7FDE.1030102@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/10/2013 03:53 AM, Simon Glass wrote: > On Tue, Jul 9, 2013 at 9:59 PM, Stephen Warren > wrote: > > On 07/09/2013 01:34 PM, Tom Rini wrote: > > Like 'bootm', 'bootz' needs to consume 'bootz' so that the rest of the > > state functions will work. > > I found that the Raspberry Pi was randomly crashing with recent > u-boot/master (bisect points at/near commit 35fc84f "Refactor the bootm > command to reduce code duplication"; there is some slight variation in > symptoms around there), or sometimes just spewing errors from bootz. I > found the following commits on the mailing list: > > > e1ec5e0 cmd_bootm.c: Make bootz handle BOOTM_STATE_FINDOTHER itself > > c83a89d cmd_bootm.c: Make bootz consume 'bootz' from argv, > decrement argc > > d18cab6 bootm: Add the missing PREP stage to bootz and correct > image handling > > 4766b32 bootm: Clean up bootz_setup() function > > f65d734 bootm: Require boot function only if it is about to be used > > bf6f341 bootm: Disable interrupts only when loading > > a01d5e4 bootm: Handle errors consistently > > ... and the combination of all 7 of them (but not just Simon's 5 > patches) seems to solve this, so, > > Tested-by: Stephen Warren > Thanks Stephen. Is this with an attached dtb or not? What 'bootz' > command line are you testing here? I just want to make sure we are > covering all the options This is a separate kernel and DTB; the command-line is roughly: bootz addr_of_zimage - addr_of_dtb