From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 11 Jul 2013 10:21:48 +0200 Subject: [U-Boot] twister: usb host support In-Reply-To: <51DD85F4.1020505@myspectrum.nl> References: <51DC68AC.5090904@myspectrum.nl> <51DD6F35.6070305@denx.de> <51DD85F4.1020505@myspectrum.nl> Message-ID: <51DE6B1C.7070400@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jeroen, On 10/07/2013 18:04, Jeroen Hofstee wrote: >> @@ -92,9 +92,6 @@ int board_init(void) >> enable_gpmc_cs_config(gpmc_XR16L2751, &gpmc_cfg->cs[3], >> XR16L2751_UART2_BASE, GPMC_SIZE_16M); >> >> - gpio_request(CONFIG_OMAP_EHCI_PHY1_RESET_GPIO, "USB_PHY1_RESET"); >> - gpio_direction_output(CONFIG_OMAP_EHCI_PHY1_RESET_GPIO, 1); >> - >> See my concerns above. Do not reset the hub in the kernel ? > > I don't get the last part, but feedback from Technexion is > needed first to remove all the guess, maybe etc. If it has a > valid function, not setting it's value might not be such a > good idea... I think we could safe drop the two lines. In fact, this code is redundant and it is already called inside the omap_ehci_phy_reset() function. No changes in behavior if we remove this lines from board_init(). Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================