From: Sricharan R <r.sricharan@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [[PATCH v2 3/6] ARM: OMAP5: USB: Add OMAP5 common USB EHCI information
Date: Thu, 11 Jul 2013 15:01:22 +0530 [thread overview]
Message-ID: <51DE7B6A.1070708@ti.com> (raw)
In-Reply-To: <51DE731F.6030706@ti.com>
On Thursday 11 July 2013 02:25 PM, Roger Quadros wrote:
> On 07/11/2013 11:35 AM, Sricharan R wrote:
>> On Thursday 11 July 2013 01:28 PM, Roger Quadros wrote:
>>> On 07/11/2013 06:51 AM, Lokesh Vutla wrote:
>>>> On Thursday 11 July 2013 01:35 AM, Dan Murphy wrote:
>>>>> * Enable the OMAP5 EHCI host clocks
>>>>> * Add OMAP5 EHCI register definitions
>>>>> * Add OMAP5 ES2 host revision
>>>>>
>>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>>>> ---
>>>>> arch/arm/cpu/armv7/omap5/hw_data.c | 13 ++++++++++
>>>>> arch/arm/include/asm/arch-omap5/clock.h | 6 +++++
>>>>> arch/arm/include/asm/arch-omap5/ehci.h | 43 +++++++++++++++++++++++++++++++
>>>>> arch/arm/include/asm/ehci-omap.h | 1 +
>>>>> drivers/usb/host/ehci-omap.c | 2 +-
>>>>> 5 files changed, 64 insertions(+), 1 deletion(-)
>>>>> create mode 100644 arch/arm/include/asm/arch-omap5/ehci.h
>>>>>
>>>>> diff --git a/arch/arm/cpu/armv7/omap5/hw_data.c b/arch/arm/cpu/armv7/omap5/hw_data.c
>>>>> index 56cf1f8..055f058 100644
>>>>> --- a/arch/arm/cpu/armv7/omap5/hw_data.c
>>>>> +++ b/arch/arm/cpu/armv7/omap5/hw_data.c
>>>>> @@ -412,6 +412,8 @@ void enable_basic_clocks(void)
>>>>> (*prcm)->cm_l4per_gpio4_clkctrl,
>>>>> (*prcm)->cm_l4per_gpio5_clkctrl,
>>>>> (*prcm)->cm_l4per_gpio6_clkctrl,
>>>>> + (*prcm)->cm_clksel_usb_60mhz,
>>>>> + (*prcm)->cm_l3init_hsusbtll_clkctrl,
>>>> guard this with CONFIG_USB_EHCI please or it ll
>>>> throw an error for DRA7xx boards.
>>> why is DRA7xx using omap5/hw_data.c?
>>>
>>> doesn't it qualify for its own SoC directory?
>> We tried to keep common things for OMAP5/DRA intact and
>> added the difference. The above clocks list was same for both.
>> In fact there is no armv7/dra directory at all.
> If there is no directory, it could be created I suppose.
> IMHO it would become ugly soon if it doesn't have its own hw_data.
I am not much against it, it might look clean but would result in some code
duplication. I feel we should do it if we add another DRA variant.
Regards,
Sricharan
next prev parent reply other threads:[~2013-07-11 9:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 20:05 [U-Boot] OMAP5 USB EHCI Dan Murphy
2013-07-10 20:05 ` [U-Boot] [[PATCH v2 1/6] omap5: uevm: Change the board name to correct name Dan Murphy
2013-07-10 23:48 ` Nishanth Menon
2013-07-10 20:05 ` [U-Boot] [[PATCH v2 2/6] ARM: OMAP5: Power: Add USB LDO9 enable interface Dan Murphy
2013-07-11 7:56 ` Roger Quadros
2013-07-11 13:44 ` Dan Murphy
2013-07-10 20:05 ` [U-Boot] [[PATCH v2 3/6] ARM: OMAP5: USB: Add OMAP5 common USB EHCI information Dan Murphy
2013-07-11 3:51 ` Lokesh Vutla
2013-07-11 7:58 ` Roger Quadros
2013-07-11 8:35 ` Sricharan R
2013-07-11 8:55 ` Roger Quadros
2013-07-11 9:31 ` Sricharan R [this message]
2013-07-11 13:48 ` Dan Murphy
2013-07-11 14:37 ` Tom Rini
2013-07-10 20:05 ` [U-Boot] [[PATCH v2 4/6] ARM: OMAP: USB: Fix linker error when ULPI is not defined Dan Murphy
2013-07-10 20:05 ` [U-Boot] [[PATCH v2 5/6] USB: ehci: Add a weak function for resetting devices Dan Murphy
2013-07-10 22:20 ` Marek Vasut
2013-07-10 23:16 ` Dan Murphy
2013-07-11 8:11 ` Roger Quadros
2013-07-11 12:35 ` Marek Vasut
2013-07-11 14:23 ` Roger Quadros
2013-07-11 15:29 ` Dan Murphy
2013-07-15 3:19 ` Marek Vasut
2013-07-16 20:19 ` Dan Murphy
2013-07-11 16:06 ` Marek Vasut
2013-07-10 20:05 ` [U-Boot] [[PATCH v2 6/6] ARM: OMAP5-uevm: Add USB ehci support for the uEVM Dan Murphy
2013-07-11 14:46 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DE7B6A.1070708@ti.com \
--to=r.sricharan@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox