[U-Boot] [PATCH v2 6/7] am335x_evm: Add support for the NOR module on the memory cape

Tom Rini
2013-05-16T19:27:23Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/16/2013 02:54 PM, Peter Korsgaard wrote:
>>>>>> "Tom" == Tom Rini <trini@ti.com> writes:
>
> Hi,
>
>>> Perhaps the nand handling should just get moved out of
>>> gpmc_init() (or the _cs_config args should be passed to
>>> gpmc_init() ).
>
> Tom> I looked at this, on the scale of redoing omap3 too (where we
> have a lot Tom> of existing examples). The split we've got now
> works and it's harmless Tom> to re-configure CS0 in the case where
> the defaults don't work. I think Tom> this would lead us to an
> abstraction that leads to a lot of board files Tom> duplicating the
> same code.
>
> Maybe the solution is simply to have:
>
> init_gpmc_nand() and init_gpmc_nor()

It boils down to:
a) Give all of CS0 to NAND
b) Give all of CS0 to NOR
c) Split CS0 into some number of segments for whatever the board wants.

What I had looked at doing before posting was:
mem.c:
__weak void configure_gpmc_cs0() { enable nand }
gpmc_init() {
... general init ...
configure_gpmc_cs0()
}

board-fu:
void configure_gpmc_cs0() {
... let the board sort it out ...
}

But I ended up with one non-default on all of omap3,which just says
"lets re-program cs0 for our split".

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRlTMbAAoJENk4IS6UOR1WF8UP/RPtkYOn2eJ0a4NNbVD5IEIU
nEUC8yW7OMi5/F6RHIgLQjfoS7Fr2CzjN1G5I895uh/+xVX5HVNataY/OFbJO7/F
PD46AzHem/cYMuOnLhItWCKSYP/kYG9PcoIPFfGU7uS5MlC8M5BIOyBRgjJtgr/1
s+PVQq7Hjn1Ketez6q4TAB0PAEEmjE76xqHtcOFi6t3QXCAp3E+5hfOiKhrJNzEM
Jqmp8xG02goFyxwyAC22LtQZe0E3nG/JnQwQx7eDbBNDjX2OwJqsRiLB2St8slgs
NGSzDipqAw399VeXHrZ0lRljGnm8xAxNIvQyTMO+sJwWnNUcmmlRlS+uZLOpzBen
xehAY7EBjt0/zM6zQ1Eo82oY9EQ1kuJg9BAhvepkgXoDWqn4B2eKdOtqFxilrbG5
QDiipqnh3o8WX4HEg8eaOaYB8WIIPYLHSeCzBchJ/BvQKceY1GuqnvUFLijpfWz1
gy281ENfrbC1PYkMkATOM10gOqTCqfisx9AzIpllylMepPvOnaB3gawOjH1rcDGV
TEKukcm+C7Gq2nBIp6LRIsZe/5OjJ/msDnMK9UqNpBhNUH6atBFIqrQi0mKrPZ24
QqSAXjHuyN0/n8po9/4MTJV8RqqOGbNs9u1ctbnGne8ptWv7AHKUdcKfy06ymIS9
u5/hEbXwfYWqNiPlgxnd
=yipX
-----END PGP SIGNATURE-----