From: Dan Murphy <dmurphy@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [[PATCH v3 1/2] gpio: tca642x: Add the tca642x gpio expander driver
Date: Thu, 11 Jul 2013 10:11:08 -0500 [thread overview]
Message-ID: <51DECB0C.3050708@ti.com> (raw)
In-Reply-To: <20130711143113.GD13531@bill-the-cat>
On 07/11/2013 09:31 AM, Tom Rini wrote:
> On Wed, Jul 10, 2013 at 03:06:02PM -0500, Dan Murphy wrote:
>
>> Add the tca642x gpio expander driver
>>
>> Datasheet:
>> http://www.ti.com/product/tca6424a
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> drivers/gpio/Makefile | 1 +
>> drivers/gpio/tca642x.c | 322 ++++++++++++++++++++++++++++++++++++++++++++++++
>> include/tca642x.h | 66 ++++++++++
>> 3 files changed, 389 insertions(+)
>> create mode 100644 drivers/gpio/tca642x.c
>> create mode 100644 include/tca642x.h
> Generally fine, but running checkpatch.pl:
> total: 0 errors, 12 warnings, 2 checks, 395 lines checked
>
> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
> MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE
> USLEEP_RANGE
>
> /tmp/gpio1.mbox has style problems, please review.
>
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> So, please address those.
>
Yeah I ran cp on this file and when I looked @ it fixing the LTLs would have made the code look messy IMHO.
But I will fix it anyway and re-submit.
--
------------------
Dan Murphy
next prev parent reply other threads:[~2013-07-11 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 20:06 [U-Boot] [[PATCH v3 1/2] gpio: tca642x: Add the tca642x gpio expander driver Dan Murphy
2013-07-10 20:06 ` [U-Boot] [[PATCH v3 2/2] gpio: omap5-uevm: Configure the tca6424 gpio expander Dan Murphy
2013-07-10 23:56 ` Nishanth Menon
2013-07-11 14:30 ` Tom Rini
2013-07-11 15:10 ` Dan Murphy
2013-07-11 15:55 ` Dan Murphy
2013-07-11 18:02 ` Nishanth Menon
2013-07-12 17:30 ` Dan Murphy
2013-07-12 21:55 ` Nishanth Menon
2013-07-11 14:31 ` [U-Boot] [[PATCH v3 1/2] gpio: tca642x: Add the tca642x gpio expander driver Tom Rini
2013-07-11 15:11 ` Dan Murphy [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-07-11 18:10 [U-Boot] [PATCH " Dan Murphy
2013-07-30 13:29 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DECB0C.3050708@ti.com \
--to=dmurphy@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox