From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 12 Jul 2013 09:27:21 +0200 Subject: [U-Boot] [PATCH] net: fec: Remove bogus flush_dcache_range() call In-Reply-To: <1373556206-29238-1-git-send-email-marex@denx.de> References: <1373556206-29238-1-git-send-email-marex@denx.de> Message-ID: <51DFAFD9.1010805@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/07/2013 17:23, Marek Vasut wrote: > Remove incorrectly called and duplicate flush_dcache_range() call > from fec_mxc driver. The call is not needed, since the caches are > already flushed in fec_tbd_init(), moreover the second argument should > be the ending address, not size. > > Signed-off-by: Marek Vasut > Reported-by: Albert Aribaud > Cc: Stefano Babic > Cc: Tom Rini > --- > drivers/net/fec_mxc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index da95e28..97bf8fe 100644 > --- a/drivers/net/fec_mxc.c > +++ b/drivers/net/fec_mxc.c > @@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd) > } > memset(fec->tbd_base, 0, size); > fec_tbd_init(fec); > - flush_dcache_range((unsigned)fec->tbd_base, size); > } > > /* > Applied to u-boot-imx (fix), thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================