* [U-Boot] [PATCH] net: fec: Remove bogus flush_dcache_range() call
@ 2013-07-11 15:23 Marek Vasut
2013-07-12 7:27 ` Stefano Babic
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2013-07-11 15:23 UTC (permalink / raw)
To: u-boot
Remove incorrectly called and duplicate flush_dcache_range() call
from fec_mxc driver. The call is not needed, since the caches are
already flushed in fec_tbd_init(), moreover the second argument should
be the ending address, not size.
Signed-off-by: Marek Vasut <marex@denx.de>
Reported-by: Albert Aribaud <albert.u.boot@aribaud.net>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Tom Rini <trini@ti.com>
---
drivers/net/fec_mxc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index da95e28..97bf8fe 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd)
}
memset(fec->tbd_base, 0, size);
fec_tbd_init(fec);
- flush_dcache_range((unsigned)fec->tbd_base, size);
}
/*
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] net: fec: Remove bogus flush_dcache_range() call
2013-07-11 15:23 [U-Boot] [PATCH] net: fec: Remove bogus flush_dcache_range() call Marek Vasut
@ 2013-07-12 7:27 ` Stefano Babic
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Babic @ 2013-07-12 7:27 UTC (permalink / raw)
To: u-boot
On 11/07/2013 17:23, Marek Vasut wrote:
> Remove incorrectly called and duplicate flush_dcache_range() call
> from fec_mxc driver. The call is not needed, since the caches are
> already flushed in fec_tbd_init(), moreover the second argument should
> be the ending address, not size.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reported-by: Albert Aribaud <albert.u.boot@aribaud.net>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@ti.com>
> ---
> drivers/net/fec_mxc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index da95e28..97bf8fe 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -560,7 +560,6 @@ static int fec_init(struct eth_device *dev, bd_t* bd)
> }
> memset(fec->tbd_base, 0, size);
> fec_tbd_init(fec);
> - flush_dcache_range((unsigned)fec->tbd_base, size);
> }
>
> /*
>
Applied to u-boot-imx (fix), thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-12 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-11 15:23 [U-Boot] [PATCH] net: fec: Remove bogus flush_dcache_range() call Marek Vasut
2013-07-12 7:27 ` Stefano Babic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox