public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x
Date: Sun, 14 Jul 2013 21:09:06 -0700	[thread overview]
Message-ID: <51E375E2.4020006@boundarydevices.com> (raw)
In-Reply-To: <CAP9ODKrSFUWPYJ1hhaqzqhMN_QPx4pTRD0cF3pKRtroO3xChkg@mail.gmail.com>

On 07/14/2013 07:58 PM, Otavio Salvador wrote:
> On Sun, Jul 14, 2013 at 11:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> Hi Otavio,
>>
>> On Sun, Jul 14, 2013 at 11:44 PM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>> On Sun, Jul 14, 2013 at 11:40 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>>
>>>> mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the
>>>> code duplication and only use the nitrogen6x source code to make board code
>>>> maintainance easier.
>>>>
>>>> Tested booting a mainline device tree kernel on a mx6qsabrelite board.
>>>>
>>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> I think this is a huge improvement I am just not sure about the
>>> environment preserving for sabrelite. I think most people using
>>> sabrelite end using the U-Boot from SPI NOR.
>>
>> I can't say whether SPI NOR or SD card is the most common medium for
>> storing the environment variables for sabrelite, but my main goal here
>> was to try to keep compability with existing code.
>>
>> Currently mx6qsabrelite defines CONFIG_ENV_IS_IN_MMC, so I kept the
>> same here. This patch introduces no change in functional behaviour.
>>
>> If we think CONFIG_ENV_IS_IN_xxx should be changed, then this is
>> something to be handled by a separate patch.
>
> Agreed :-)
>
> Reviewed-by: Otavio Salvador <otavio@ossystems.com.br>
>

+1

We should also add something to the README file though.

  reply	other threads:[~2013-07-15  4:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15  2:40 [U-Boot] [PATCH] mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x Fabio Estevam
2013-07-15  2:44 ` Otavio Salvador
2013-07-15  2:52   ` Fabio Estevam
2013-07-15  2:58     ` Otavio Salvador
2013-07-15  4:09       ` Eric Nelson [this message]
2013-07-15  4:23         ` Fabio Estevam
2013-07-15 14:20           ` Eric Nelson
2013-07-15 14:55             ` [U-Boot] Antwort: " Stephan Bauroth
2013-07-15 15:31               ` Eric Nelson
2013-07-15 15:33             ` [U-Boot] " Fabio Estevam
2013-07-15 15:43               ` Eric Nelson
2013-07-15  7:14 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E375E2.4020006@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox