From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Nelson Date: Sun, 14 Jul 2013 21:09:06 -0700 Subject: [U-Boot] [PATCH] mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x In-Reply-To: References: <1373856014-20390-1-git-send-email-festevam@gmail.com> Message-ID: <51E375E2.4020006@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/14/2013 07:58 PM, Otavio Salvador wrote: > On Sun, Jul 14, 2013 at 11:52 PM, Fabio Estevam wrote: >> Hi Otavio, >> >> On Sun, Jul 14, 2013 at 11:44 PM, Otavio Salvador >> wrote: >>> On Sun, Jul 14, 2013 at 11:40 PM, Fabio Estevam wrote: >>>> From: Fabio Estevam >>>> >>>> mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid the >>>> code duplication and only use the nitrogen6x source code to make board code >>>> maintainance easier. >>>> >>>> Tested booting a mainline device tree kernel on a mx6qsabrelite board. >>>> >>>> Signed-off-by: Fabio Estevam >>> >>> I think this is a huge improvement I am just not sure about the >>> environment preserving for sabrelite. I think most people using >>> sabrelite end using the U-Boot from SPI NOR. >> >> I can't say whether SPI NOR or SD card is the most common medium for >> storing the environment variables for sabrelite, but my main goal here >> was to try to keep compability with existing code. >> >> Currently mx6qsabrelite defines CONFIG_ENV_IS_IN_MMC, so I kept the >> same here. This patch introduces no change in functional behaviour. >> >> If we think CONFIG_ENV_IS_IN_xxx should be changed, then this is >> something to be handled by a separate patch. > > Agreed :-) > > Reviewed-by: Otavio Salvador > +1 We should also add something to the README file though.