From mboxrd@z Thu Jan  1 00:00:00 1970
From: Troy Kisky <troy.kisky@boundarydevices.com>
Date: Tue, 16 Jul 2013 17:28:24 -0700
Subject: [U-Boot] [PATCH RFC V1 10/18] usb: gadget: ether: return error
 from rx_submit if no request
In-Reply-To: <1374007666-2749-11-git-send-email-troy.kisky@boundarydevices.com>
References: <1374007666-2749-1-git-send-email-troy.kisky@boundarydevices.com>
	<1374007666-2749-11-git-send-email-troy.kisky@boundarydevices.com>
Message-ID: <51E5E528.70409@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 7/16/2013 1:47 PM, Troy Kisky wrote:
> This prevents a crash if tftpboot is given a bad filename.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> ---
>   drivers/usb/gadget/ether.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
> index e39714b..1542ca3 100644
> --- a/drivers/usb/gadget/ether.c
> +++ b/drivers/usb/gadget/ether.c
> @@ -2401,7 +2401,8 @@ static int usb_eth_init(struct eth_device *netdev, bd_t *bd)
>   	}
>   
>   	packet_received = 0;
> -	rx_submit(dev, dev->rx_req, 0);
> +	if (dev->rx_req)
> +		rx_submit(dev, dev->rx_req, 0);
>   	return 0;
>   fail:
>   	return -1;
This patch is wrong. I will put the check in rx_submit, because this 
call was not the problem.