public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Piotr Wilczek <p.wilczek@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm:exynos:gpio: fix s5p_gpio_part_max for exynos4x12
Date: Thu, 18 Jul 2013 16:10:39 +0200	[thread overview]
Message-ID: <51E7F75F.40704@samsung.com> (raw)
In-Reply-To: <1369143544-29213-1-git-send-email-p.wilczek@samsung.com>

Dear Minkyu Kang,

Could you please review this patch?

Best regards,
Piotr Wilczek

--
Samsung R&D Institute Poland
Samsung Electronics

On 05/21/2013 03:39 PM, Piotr Wilczek wrote:
> This patch fix wrong value returned by 's5p_gpio_part_max' function
> for Exynos4412.
>
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: Minkyu Kang <mk7.kang@samsung.com>
> ---
>   arch/arm/include/asm/arch-exynos/gpio.h |   17 +++++++++++++----
>   1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-exynos/gpio.h b/arch/arm/include/asm/arch-exynos/gpio.h
> index cfe1024..20a4e3f 100644
> --- a/arch/arm/include/asm/arch-exynos/gpio.h
> +++ b/arch/arm/include/asm/arch-exynos/gpio.h
> @@ -303,10 +303,19 @@ static inline unsigned int s5p_gpio_part_max(int nr)
>   			return EXYNOS5_GPIO_PART2_MAX;
>
>   	} else if (cpu_is_exynos4()) {
> -		if (nr < EXYNOS4_GPIO_PART1_MAX)
> -			return 0;
> -		else
> -			return EXYNOS4_GPIO_PART1_MAX;
> +		if (proid_is_exynos4412()) {
> +			if (nr < EXYNOS4X12_GPIO_PART1_MAX)
> +				return 0;
> +			else if (nr < EXYNOS4X12_GPIO_PART2_MAX)
> +				return EXYNOS4X12_GPIO_PART1_MAX;
> +			else
> +				return EXYNOS4X12_GPIO_PART2_MAX;
> +		} else {
> +			if (nr < EXYNOS4_GPIO_PART1_MAX)
> +				return 0;
> +			else
> +				return EXYNOS4_GPIO_PART1_MAX;
> +		}
>   	}
>
>   	return 0;
>

  reply	other threads:[~2013-07-18 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21 13:39 [U-Boot] [PATCH] arm:exynos:gpio: fix s5p_gpio_part_max for exynos4x12 Piotr Wilczek
2013-07-18 14:10 ` Piotr Wilczek [this message]
2013-07-19  5:43   ` Minkyu Kang
2013-08-06 11:24 ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E7F75F.40704@samsung.com \
    --to=p.wilczek@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox