public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module
Date: Mon, 22 Jul 2013 10:46:39 +0200	[thread overview]
Message-ID: <51ECF16F.3000008@denx.de> (raw)
In-Reply-To: <1374480877-20643-1-git-send-email-rogerq@ti.com>

On 07/22/2013 10:14 AM, Roger Quadros wrote:
> Fixes NFS root problems with Beagle (3530 ES1.0) when used with
> external USB-ethernet adapter and "USB start" command used within
> u-boot.
> 
> Soft resetting the UHH module causes instability issues on
> all OMAPs so we just avoid it.
> 
> See OMAP36xx Errata
>   i571: USB host EHCI may stall when entering smart-standby mode
>   i660: USBHOST Configured In Smart-Idle Can Lead To a Deadlock
> 
> On OMAP4/5, soft-resetting the UHH module can put it into
> Smart-Idle mode and lead to a deadlock.
> 
> On OMAP3 this doesn't seem to be the case but still instabilities
> are observed on beagle (3530 ES1.0) if soft-reset is used.
>  e.g. NFS root failures with Linux kernel.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Thanks a lot for fixing this. With this patch, beagleboard is able to
boot into an NFS root-fs. Even when USB is used previously in U-Boot.
Without this patch NFS booting hangs randomly at some time.

So:

Tested-by: Stefan Roese <sr@denx.de>

Note: I think its a bit too late to take this patch into this release.
So I suggest to apply it in the next merge-window.

Thanks,
Stefan

  reply	other threads:[~2013-07-22  8:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22  8:14 [U-Boot] [PATCH] usb: ehci-omap: Don't softreset USB High-speed Host (UHH) Module Roger Quadros
2013-07-22  8:46 ` Stefan Roese [this message]
2013-07-22  8:52 ` Marek Vasut
2013-07-23 18:53   ` Dan Murphy
2013-07-24  3:36 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51ECF16F.3000008@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox