From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sourav Poddar Date: Tue, 23 Jul 2013 15:03:41 +0530 Subject: [U-Boot] [PATCHv2 3/8] spi: add TI QSPI driver In-Reply-To: <20130723092345.EB273380ADF@gemini.denx.de> References: <1374569979-28660-1-git-send-email-sourav.poddar@ti.com> <1374569979-28660-4-git-send-email-sourav.poddar@ti.com> <20130723092345.EB273380ADF@gemini.denx.de> Message-ID: <51EE4DF5.8000700@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 23 July 2013 02:53 PM, Wolfgang Denk wrote: > Dear Sourav Poddar, > > In message<1374569979-28660-4-git-send-email-sourav.poddar@ti.com> you wrote: >> From: Matt Porter >> >> Adds a SPI master driver for the TI QSPI peripheral. >> >> Signed-off-by: Matt Porter >> Signed-off-by: Sourav Poddar >> --- >> drivers/spi/Makefile | 1 + >> drivers/spi/ti_qspi.c | 262 +++++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 263 insertions(+), 0 deletions(-) >> create mode 100644 drivers/spi/ti_qspi.c > when submitting a new version of a patch or patch series, it is > mandatory to supply a chancgelog that desribes what you changed > compareds to previous versions of the patch. This is necessary so > that reviewers can see which of their hints were taken into account, > etc. > > This is missing in all you patches of this series. Ok. will add in the next version. > Also, please run all your patches through checkpatch _before_ > submitting. For this patch, I get some "line over 80 characters" > wanings that need to be fixed. This should not happen. Please be > more careful next time. > Hmm...will check and remove. > Best regards, > > Wolfgang Denk >