public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: goni: remove config.mk file
Date: Fri, 26 Jul 2013 10:45:09 +0900	[thread overview]
Message-ID: <51F1D4A5.9020002@samsung.com> (raw)
In-Reply-To: <20130725130521.56bfd517@amdc308.digital.local>

Dear Lukasz,

On 25/07/13 20:05, Lukasz Majewski wrote:
> On Thu, 25 Jul 2013 10:45:35 +0900 Minkyu Kang mk7.kang at samsung.com
> wrote,
> 
> Hi Minkyu,
> 
>> Since config.mk is deprecated, remove this file,
>> and move CONFIG_SYS_TEXT_BASE define to config file.
>>
>> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
>> ---
>>  board/samsung/goni/config.mk |   34
>> ---------------------------------- include/configs/s5p_goni.h   |
>> 3 +++ 2 files changed, 3 insertions(+), 34 deletions(-)
>>  delete mode 100644 board/samsung/goni/config.mk
>>
>> diff --git a/board/samsung/goni/config.mk
>> b/board/samsung/goni/config.mk deleted file mode 100644
>> index e4581ca..0000000
>> --- a/board/samsung/goni/config.mk
>> +++ /dev/null
>> @@ -1,34 +0,0 @@
>> -#
>> -# Copyright (C) 2010 Samsung Electronics
>> -# Kyungmin Park <kyungmin.park@samsung.com>
>> -#
>> -# See file CREDITS for list of people who contributed to this
>> -# project.
>> -#
>> -# This program is free software; you can redistribute it and/or
>> -# modify it under the terms of the GNU General Public License as
>> -# published by the Free Software Foundation; either version 2 of
>> -# the License, or (at your option) any later version.
>> -#
>> -# This program is distributed in the hope that it will be useful,
>> -# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> -# GNU General Public License for more details.
>> -#
>> -# You should have received a copy of the GNU General Public License
>> -# along with this program; if not, write to the Free Software
>> -# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> -# MA 02111-1307 USA
>> -#
>> -
>> -# On S5PC100 we use the 128 MiB OneDRAM bank at
>> -#
>> -# 0x30000000 to 0x35000000 (80MiB)
>> -# 0x38000000 to 0x40000000 (128MiB)
>> -#
>> -# On S5PC110 we use the 128 MiB OneDRAM bank at
>> -#
>> -# 0x30000000 to 0x35000000 (80MiB)
>> -# 0x40000000 to 0x50000000 (256MiB)
>> -#
>> -CONFIG_SYS_TEXT_BASE = 0x34800000
>> diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
>> index 56e8347..02355a6 100644
>> --- a/include/configs/s5p_goni.h
>> +++ b/include/configs/s5p_goni.h
>> @@ -45,6 +45,9 @@
>>  /* DRAM Base */
>>  #define CONFIG_SYS_SDRAM_BASE		0x30000000
> 
> Would it be possible to change the DMC0 (Memory controller) base address
> from 0x30000000 to 0x20000000? 
> 
> This is what the Linux kernel expects.
> (at /arch/arm/mach-s5pv210/include/mach/memory.h)
> 

Maybe it will be possible. but not this patch.
This patch is for removing config.mk.

btw, I don't have goni target any more.
So, if possible.. could you send the patch for it?

> 
>>  
>> +/* Text Base */
>> +#define CONFIG_SYS_TEXT_BASE		0x34800000
>> +
>>  #define CONFIG_SETUP_MEMORY_TAGS
>>  #define CONFIG_CMDLINE_TAG
>>  #define CONFIG_INITRD_TAG
> 
> 
> 

Thanks,
Minkyu Kang.

  reply	other threads:[~2013-07-26  1:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25  1:45 [U-Boot] [PATCH 2/2] arm: goni: remove config.mk file Minkyu Kang
2013-07-25 11:05 ` Lukasz Majewski
2013-07-26  1:45   ` Minkyu Kang [this message]
2013-07-26  6:59     ` Lukasz Majewski
2013-08-06  3:00       ` Minkyu Kang
2013-08-06 11:57 ` [U-Boot] [PATCH 2/2 v2] " Minkyu Kang
2013-08-28  1:21   ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F1D4A5.9020002@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox