From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: mxc_ipuv3: fix memory alignment of framebuffer
Date: Fri, 26 Jul 2013 17:56:07 -0700 [thread overview]
Message-ID: <51F31AA7.5040207@boundarydevices.com> (raw)
In-Reply-To: <201307262138.53588.marex@denx.de>
On 07/26/2013 12:38 PM, Marek Vasut wrote:
> Dear Eric Nelson,
>
>>>> - fbi->screen_base = (char *)malloc(fbi->fix.smem_len);
>>>> + fbi->screen_base = (char *)memalign(ARCH_DMA_MINALIGN,
>>>> + fbi->fix.smem_len);
>>>
>>> You might want to round-up the length too, like I did in the MXS driver.
>>
>> Did you really run across a display whose size wasn't a multiple of
>> 32, or is this rounding just in muscle-memory for you?
>
> Palm devices with PXA27x (PalmT5, PalmLD, PalmTX) had 484x324 LCDs ;-)
>
With as much cache-enablement as you've done lately, I have a feeling
you round up at the grocery store or pub ;)
prev parent reply other threads:[~2013-07-27 0:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 0:35 [U-Boot] [PATCH] video: mxc_ipuv3: fix memory alignment of framebuffer Eric Nelson
2013-07-26 4:27 ` Marek Vasut
2013-07-26 14:35 ` Eric Nelson
2013-07-26 19:38 ` Marek Vasut
2013-07-27 0:56 ` Eric Nelson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F31AA7.5040207@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox