* [U-Boot] [PATCH] sf: spansion: Add support for S25FL512S_256K
@ 2013-07-31 7:43 Nobuhiro Iwamatsu
2013-07-31 10:31 ` Michal Simek
0 siblings, 1 reply; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-07-31 7:43 UTC (permalink / raw)
To: u-boot
Add support for Spansion S25FL512S_256K SPI flash.
Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
drivers/mtd/spi/spansion.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
index 47a4897..a7dc096 100644
--- a/drivers/mtd/spi/spansion.c
+++ b/drivers/mtd/spi/spansion.c
@@ -1,4 +1,5 @@
/*
+ * Copyright (C) 2013 Renesas Electronics Corporation
* Copyright (C) 2009 Freescale Semiconductor, Inc.
*
* Author: Mingkai Hu (Mingkai.hu at freescale.com)
@@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
.nr_sectors = 1024,
.name = "S25FL512S_64K",
},
+ {
+ .idcode1 = 0x0220,
+ .idcode2 = 0x4d00,
+ .pages_per_sector = 1024,
+ .nr_sectors = 256,
+ .name = "S25FL512S_256K",
+ },
};
struct spi_flash *spi_flash_probe_spansion(struct spi_slave *spi, u8 *idcode)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] sf: spansion: Add support for S25FL512S_256K
2013-07-31 7:43 [U-Boot] [PATCH] sf: spansion: Add support for S25FL512S_256K Nobuhiro Iwamatsu
@ 2013-07-31 10:31 ` Michal Simek
2013-08-01 0:16 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 4+ messages in thread
From: Michal Simek @ 2013-07-31 10:31 UTC (permalink / raw)
To: u-boot
On 07/31/2013 09:43 AM, Nobuhiro Iwamatsu wrote:
> Add support for Spansion S25FL512S_256K SPI flash.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> drivers/mtd/spi/spansion.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
> index 47a4897..a7dc096 100644
> --- a/drivers/mtd/spi/spansion.c
> +++ b/drivers/mtd/spi/spansion.c
> @@ -1,4 +1,5 @@
> /*
> + * Copyright (C) 2013 Renesas Electronics Corporation
I don't think that this is huge contribution that you should also update header.
> * Copyright (C) 2009 Freescale Semiconductor, Inc.
> *
> * Author: Mingkai Hu (Mingkai.hu at freescale.com)
> @@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
> .nr_sectors = 1024,
> .name = "S25FL512S_64K",
> },
> + {
> + .idcode1 = 0x0220,
> + .idcode2 = 0x4d00,
> + .pages_per_sector = 1024,
> + .nr_sectors = 256,
> + .name = "S25FL512S_256K",
> + },
Jagan sent very similar patch
http://lists.denx.de/pipermail/u-boot/2013-May/155501.html
but nr_sectors and pages_per_sector are swapped.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130731/a5d64088/attachment.pgp>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] sf: spansion: Add support for S25FL512S_256K
2013-07-31 10:31 ` Michal Simek
@ 2013-08-01 0:16 ` Nobuhiro Iwamatsu
2013-10-03 15:55 ` Jagan Teki
0 siblings, 1 reply; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-08-01 0:16 UTC (permalink / raw)
To: u-boot
Hi,
Thank you for your review.
2013/7/31 Michal Simek <monstr@monstr.eu>:
> On 07/31/2013 09:43 AM, Nobuhiro Iwamatsu wrote:
>> Add support for Spansion S25FL512S_256K SPI flash.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> ---
>> drivers/mtd/spi/spansion.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
>> index 47a4897..a7dc096 100644
>> --- a/drivers/mtd/spi/spansion.c
>> +++ b/drivers/mtd/spi/spansion.c
>> @@ -1,4 +1,5 @@
>> /*
>> + * Copyright (C) 2013 Renesas Electronics Corporation
>
> I don't think that this is huge contribution that you should also update header.
>
Hm, OK. I remove this line.
>> * Copyright (C) 2009 Freescale Semiconductor, Inc.
>> *
>> * Author: Mingkai Hu (Mingkai.hu at freescale.com)
>> @@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
>> .nr_sectors = 1024,
>> .name = "S25FL512S_64K",
>> },
>> + {
>> + .idcode1 = 0x0220,
>> + .idcode2 = 0x4d00,
>> + .pages_per_sector = 1024,
>> + .nr_sectors = 256,
>> + .name = "S25FL512S_256K",
>> + },
>
> Jagan sent very similar patch
> http://lists.denx.de/pipermail/u-boot/2013-May/155501.html
> but nr_sectors and pages_per_sector are swapped.
I did not notice this patch, thanks.
I wait patch of Jagan to be merged.
Best regards,
Nobuhiro
>
> Thanks,
> Michal
>
> --
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
--
Nobuhiro Iwamatsu
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] sf: spansion: Add support for S25FL512S_256K
2013-08-01 0:16 ` Nobuhiro Iwamatsu
@ 2013-10-03 15:55 ` Jagan Teki
0 siblings, 0 replies; 4+ messages in thread
From: Jagan Teki @ 2013-10-03 15:55 UTC (permalink / raw)
To: u-boot
Please try to test your part in u-boot-spi.git with master-probe branch.
We have a new probe setup code.
Let me know for any issues or concerns.
On Thu, Aug 1, 2013 at 5:46 AM, Nobuhiro Iwamatsu
<nobuhiro.iwamatsu.yj@renesas.com> wrote:
> Hi,
>
> Thank you for your review.
>
> 2013/7/31 Michal Simek <monstr@monstr.eu>:
>> On 07/31/2013 09:43 AM, Nobuhiro Iwamatsu wrote:
>>> Add support for Spansion S25FL512S_256K SPI flash.
>>>
>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>>> ---
>>> drivers/mtd/spi/spansion.c | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
>>> index 47a4897..a7dc096 100644
>>> --- a/drivers/mtd/spi/spansion.c
>>> +++ b/drivers/mtd/spi/spansion.c
>>> @@ -1,4 +1,5 @@
>>> /*
>>> + * Copyright (C) 2013 Renesas Electronics Corporation
>>
>> I don't think that this is huge contribution that you should also update header.
>>
>
> Hm, OK. I remove this line.
>
>>> * Copyright (C) 2009 Freescale Semiconductor, Inc.
>>> *
>>> * Author: Mingkai Hu (Mingkai.hu at freescale.com)
>>> @@ -101,6 +102,13 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
>>> .nr_sectors = 1024,
>>> .name = "S25FL512S_64K",
>>> },
>>> + {
>>> + .idcode1 = 0x0220,
>>> + .idcode2 = 0x4d00,
>>> + .pages_per_sector = 1024,
>>> + .nr_sectors = 256,
>>> + .name = "S25FL512S_256K",
>>> + },
>>
>> Jagan sent very similar patch
>> http://lists.denx.de/pipermail/u-boot/2013-May/155501.html
>> but nr_sectors and pages_per_sector are swapped.
>
> I did not notice this patch, thanks.
> I wait patch of Jagan to be merged.
>
> Best regards,
> Nobuhiro
>
>>
>> Thanks,
>> Michal
>>
>> --
>> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
>> w: www.monstr.eu p: +42-0-721842854
>> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
>> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
>> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
>>
>>
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
>
>
> --
> Nobuhiro Iwamatsu
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
--
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-03 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31 7:43 [U-Boot] [PATCH] sf: spansion: Add support for S25FL512S_256K Nobuhiro Iwamatsu
2013-07-31 10:31 ` Michal Simek
2013-08-01 0:16 ` Nobuhiro Iwamatsu
2013-10-03 15:55 ` Jagan Teki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox