From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Date: Wed, 31 Jul 2013 14:43:34 -0500 Subject: [U-Boot] [PATCH v3 7/7] ARM: OMAP5-uevm: Add usb device reset API In-Reply-To: <201307180630.55940.marex@denx.de> References: <1374092167-27645-1-git-send-email-dmurphy@ti.com> <1374092167-27645-8-git-send-email-dmurphy@ti.com> <201307180630.55940.marex@denx.de> Message-ID: <51F968E6.6050603@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Marek On 07/17/2013 11:30 PM, Marek Vasut wrote: > Dear Dan Murphy, > >> Add the call back to reset the LAN9730 after >> the FEAT_POWER has been called. >> >> Signed-off-by: Dan Murphy >> --- >> v3 - Added this patch to separate the patch series - >> http://patchwork.ozlabs.org/patch/258229/ >> >> board/ti/omap5_uevm/evm.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/board/ti/omap5_uevm/evm.c b/board/ti/omap5_uevm/evm.c >> index 9add0fd..42253fd 100644 >> --- a/board/ti/omap5_uevm/evm.c >> +++ b/board/ti/omap5_uevm/evm.c >> @@ -31,6 +31,7 @@ >> >> #ifdef CONFIG_USB_EHCI >> #include >> +#include >> #include >> #include >> >> @@ -169,4 +170,14 @@ int ehci_hcd_stop(void) >> ret = omap_ehci_hcd_stop(); >> return ret; >> } >> + >> +void usb_hub_reset_devices(int port) >> +{ >> + /* The LAN9730 needs to be reset after the port power has been set. */ >> + if (port == 3) { >> + gpio_direction_output(CONFIG_OMAP_EHCI_PHY1_RESET_GPIO, 0); >> + udelay(10); >> + gpio_direction_output(CONFIG_OMAP_EHCI_PHY1_RESET_GPIO, 1); >> + } >> +} > Do you really need a config option for a board-specific GPIO used in a board > file? Sorry I missed addressing this comment. I am not adding a config option but I am re-using the CONFIG option that already exists. I did not want to define the GPIO number twice. This CONFIG option is also used in the ehci-omap.c file. Dan > >> #endif > Best regards, > Marek Vasut -- ------------------ Dan Murphy