public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i2c: soft: Fix typo in CONFIG_SYS_I2C_SOFT_SPEED
Date: Thu, 01 Aug 2013 06:40:41 +0200	[thread overview]
Message-ID: <51F9E6C9.6050902@denx.de> (raw)
In-Reply-To: <1375268602-30546-1-git-send-email-marex@denx.de>

Hello Marek,

Am 31.07.2013 13:03, schrieb Marek Vasut:
> In case only the CONFIG_SYS_I2C_SPEED is set in configuration file,
> the CONFIG_SYS_I2C_SOFT_SPEED is defined as CONFIG_SYS_I2C_SPEED.
> The CONFIG_SYS_I2C_SOFT_SPEED is then used throughout the driver.
>
> Unfortunatelly, due to a typo in the driver, instead of defining
> CONFIG_SYS_I2C_SOFT_SPEED, an CONFIG_SYS_SOFT_I2C_SPEED was defined
> and therefore the driver failed to compile. The same applies for
> CONFIG_SYS_I2C_SOFT_SLAVE , where the swap happens as well.
>
> This patch fixes the issue.
>
> Signed-off-by: Marek Vasut<marex@denx.de>
> Cc: Heiko Schocher<hs@denx.de>
> ---
>   drivers/i2c/soft_i2c.c |    8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

Thanks for this fix. Hmm...

[hs at pollux u-boot]$ grep -lr CONFIG_SYS_SOFT_I2C_SPEED .
./include/configs/blackstamp.h
./drivers/i2c/soft_i2c.c
[hs at pollux u-boot]$

There is one more typo ... could you fix this too, as I want
to have this in one commit?

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2013-08-01  4:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-31 11:03 [U-Boot] [PATCH] i2c: soft: Fix typo in CONFIG_SYS_I2C_SOFT_SPEED Marek Vasut
2013-08-01  4:40 ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F9E6C9.6050902@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox