From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Thu, 01 Aug 2013 06:40:41 +0200 Subject: [U-Boot] [PATCH] i2c: soft: Fix typo in CONFIG_SYS_I2C_SOFT_SPEED In-Reply-To: <1375268602-30546-1-git-send-email-marex@denx.de> References: <1375268602-30546-1-git-send-email-marex@denx.de> Message-ID: <51F9E6C9.6050902@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Marek, Am 31.07.2013 13:03, schrieb Marek Vasut: > In case only the CONFIG_SYS_I2C_SPEED is set in configuration file, > the CONFIG_SYS_I2C_SOFT_SPEED is defined as CONFIG_SYS_I2C_SPEED. > The CONFIG_SYS_I2C_SOFT_SPEED is then used throughout the driver. > > Unfortunatelly, due to a typo in the driver, instead of defining > CONFIG_SYS_I2C_SOFT_SPEED, an CONFIG_SYS_SOFT_I2C_SPEED was defined > and therefore the driver failed to compile. The same applies for > CONFIG_SYS_I2C_SOFT_SLAVE , where the swap happens as well. > > This patch fixes the issue. > > Signed-off-by: Marek Vasut > Cc: Heiko Schocher > --- > drivers/i2c/soft_i2c.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Thanks for this fix. Hmm... [hs at pollux u-boot]$ grep -lr CONFIG_SYS_SOFT_I2C_SPEED . ./include/configs/blackstamp.h ./drivers/i2c/soft_i2c.c [hs at pollux u-boot]$ There is one more typo ... could you fix this too, as I want to have this in one commit? Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany