public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Mac address warning
Date: Fri, 02 Aug 2013 07:39:55 -0700	[thread overview]
Message-ID: <51FBC4BB.4000501@boundarydevices.com> (raw)
In-Reply-To: <20130802141610.GC5164@bill-the-cat>

Thanks Tom,

On 08/02/2013 07:16 AM, Tom Rini wrote:
> On Fri, Aug 02, 2013 at 03:08:36PM +0200, Stefano Babic wrote:
>> Hi Eric,
>>
>> On 02/08/2013 01:28, Eric Nelson wrote:
>>> Hi all,
>>>
>>> While testing Troy's usbnet patches, I was reminded of
>>> this mysterious warning issued when the environment has
>>> no mac address stored, but the device provides one:
>>>
>>>      printf("\nWarning: %s using MAC address from net device\n",
>>>              dev->name);
>>>
>>> Why is this a warning? It's the out-of-the box default
>>> for new boards who haven't saved a mac address to the
>>> persistent environment.
>>
>> Well, I have found it very useful in case I set explicitely the ethaddr
>> variable, so I know where the MAC address comes from. Do you find it
>> disturbing ? Maybe we could replace "warning" with "info".
>
> On am335x the message we use is:
> <ethaddr> not set. Validating first E-fuse MAC
> And then validate it, and setenv.
>
I think this points out the issue. The fec_mxc driver isn't
setting a default ethaddr environment variable.

Stefano, we've had lots of questions from customers because
ethaddr is empty in the normal case (no environment saved).

I'll figure out where this goes and submit a patch.

Regards,


Eric

  parent reply	other threads:[~2013-08-02 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-01 23:28 [U-Boot] Mac address warning Eric Nelson
2013-08-02 13:08 ` Stefano Babic
2013-08-02 14:16   ` Tom Rini
2013-08-02 14:36     ` Stefano Babic
2013-08-02 14:45       ` Tom Rini
2013-08-02 14:39     ` Eric Nelson [this message]
2013-08-04 20:24   ` Wolfgang Denk
2013-08-04 20:37     ` Eric Nelson
2013-08-04 20:17 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51FBC4BB.4000501@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox