From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 01/20] Add functions for use with i.mx6 otg udc
Date: Fri, 02 Aug 2013 16:41:25 -0700 [thread overview]
Message-ID: <51FC43A5.4010002@boundarydevices.com> (raw)
In-Reply-To: <201308030010.41510.marex@denx.de>
On 8/2/2013 3:10 PM, Marek Vasut wrote:
> Dear Troy Kisky,
>
>> On 8/2/2013 3:48 AM, Marek Vasut wrote:
>>> Dear Troy Kisky,
>>>
>>>> Add functions for use with mx6 soc
>>>> void otg_enable(void);
>>>> void reset_usb_phy1(void);
>>>>
>>>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>>>> ---
>>>>
>>>> arch/arm/cpu/armv7/mx6/soc.c | 47
>>>>
>>>> +++++++++++++++++++++++++++++++ arch/arm/include/asm/arch-mx6/crm_regs.h
>>>>
>>>> | 3 ++
>>>>
>>>> arch/arm/include/asm/arch-mx6/imx-regs.h | 17 +++++++++++
>>>> arch/arm/include/asm/arch-mx6/sys_proto.h | 4 +++
>>>> 4 files changed, 71 insertions(+)
>>> [...]
>>>
>>>> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h
>>>> b/arch/arm/include/asm/arch-mx6/imx-regs.h index 5d6bccb..3eed4d8 100644
>>>> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
>>>> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
>>>> @@ -419,6 +419,23 @@ struct cspi_regs {
>>>>
>>>> ECSPI5_BASE_ADDR
>>>>
>>>> #endif
>>>>
>>>> +struct set_clr_tog {
>>>> + u32 val;
>>>> + u32 set;
>>>> + u32 clr;
>>>> + u32 tog;
>>>> +};
>>>> +
>>>> +struct usbphy {
>>>> + struct set_clr_tog pwd;
>>>> + struct set_clr_tog tx;
>>>> + struct set_clr_tog rx;
>>>> + struct set_clr_tog ctrl;
>>>> +};
>>> Maybe you want to keep the naming here consistent with MX28 and MX6?
>>>
>>> See arch/arm/include/asm/imx-common/regs-common.h
>>>
>>> [...]
>>>
>>> Best regards,
>>> Marek Vasut
>> Wow, arch/arm/include/asm/imx-common/regs-common.h
>> is damn ugly. I personally hate unions even when there is a very good
>> reason.
>>
>> Would you like to see me attempt to clean it up or do you like it the
>> way it is
>> since your commit started the unions ?
> I think it works perfectly well and does exactly what it's supposed to do.
> What's your problem with the file?
>
> Best regards,
> Marek Vasut
>
Why is there a union ? It looks to me like you just want to access the
same variable
with 2 naming strategies.
Troy
next prev parent reply other threads:[~2013-08-02 23:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 23:27 [U-Boot] [PATCH V3 00/20] Make mv_udc work for i.mx6 Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 01/20] Add functions for use with i.mx6 otg udc Troy Kisky
2013-08-02 10:48 ` Marek Vasut
2013-08-02 19:44 ` Troy Kisky
2013-08-02 22:10 ` Marek Vasut
2013-08-02 23:41 ` Troy Kisky [this message]
2013-08-03 1:45 ` Marek Vasut
2013-08-03 2:24 ` Troy Kisky
2013-08-03 16:47 ` Marek Vasut
2013-08-03 19:30 ` Troy Kisky
2013-08-03 22:46 ` Marek Vasut
2013-08-15 21:36 ` Marek Vasut
2013-08-16 18:20 ` Troy Kisky
2013-08-04 20:15 ` Wolfgang Denk
2013-08-05 20:15 ` Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 02/20] mx6: iomux: add GPR1 defines Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 03/20] nitrogen6x: add otg usb ethernet gadget support Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 04/20] nitrogen6x: add CONFIG_MV_UDC Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 05/20] arch-mxs/sys_proto.h: include regs-common.h Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 06/20] usb: gadget: mv_udc: fix hardware udc address for i.MX6 Troy Kisky
2013-08-02 10:53 ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 07/20] usb: gadget: config: fix unaligned access issues Troy Kisky
2013-08-02 10:57 ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 08/20] usb: gadget: mv_udc: add MX6Q specific reset Troy Kisky
2013-08-02 10:58 ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 09/20] usb: gadget: ether set wMaxPacketSize Troy Kisky
2013-08-02 10:59 ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 10/20] usb: gadget: ether: return error from rx_submit if no request Troy Kisky
2013-08-02 11:07 ` Marek Vasut
2013-08-01 23:27 ` [U-Boot] [PATCH V3 11/20] usb: gadget: mv_udc: split mv_udc.h file Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 12/20] usb: udc: add udc.h include file Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 13/20] usb: gadget: mv_udc: fix typo in error message Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 14/20] usb: gadget: mv_udc: set is_dualspeed = 1 Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 15/20] usb: gadget: mv_udc: fix full speed connections Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 16/20] usb: gadget: mv_udc: optimize bounce Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 17/20] usb: gadget: mv_udc: flush item before head Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 18/20] usb: gadget: mv_udc: optimize ep_enable Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 19/20] usb: gadget: mv_udc: zero transfer descriptor memory on probe Troy Kisky
2013-08-01 23:27 ` [U-Boot] [PATCH V3 20/20] usb: gadget: mv_udc: clear desc upon ep_disable Troy Kisky
2013-08-02 11:14 ` [U-Boot] [PATCH V3 00/20] Make mv_udc work for i.mx6 Marek Vasut
2013-08-02 14:43 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FC43A5.4010002@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox