From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Mon, 05 Aug 2013 11:59:36 -0600
Subject: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2C
 framework
In-Reply-To: <51FC7F34.1030001@denx.de>
References: <1367668903-29653-1-git-send-email-hs@denx.de>
	<1367668903-29653-9-git-send-email-hs@denx.de>
	<51F6946F.8010500@wwwdotorg.org> <51F740FD.4080505@denx.de>
	<51F81261.7020008@wwwdotorg.org> <51F81B51.6010305@wwwdotorg.org>
	<CAPnjgZ3aVkHX7Ww2LUHRpiwKU6S+sHTtrKuFeJUM7Hb8+f7bxA@mail.gmail.com>
	<51F83104.5090508@wwwdotorg.org>
	<CAPnjgZ3FAR4YB0Bf5zsv=yPUuRD1k-aMGRG6K6PvuzCFwkNZLQ@mail.gmail.com>
	<51F83570.1010909@wwwdotorg.org>
	<CAPnjgZ1Q3rJ1N=jgHAV7ythM5fwmua50Hs1B=aV0uNCDdqwbyA@mail.gmail.com>
	<51F8A4CA.7070702@denx.de> <51F9662D.1070602@wwwdotorg.org>
	<51F9E4CB.9040004@denx.de> <51F9F477.5060607@wwwdotorg.org>
	<51F9FA02.1060403@denx.de> <51FAC5FA.2000405@wwwdotorg.org>
	<51FB384A.70305@denx.de> <51FC2810.2090005@wwwdotorg.org>
	<51FC7F34.1030001@denx.de>
Message-ID: <51FFE808.40009@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/02/2013 09:55 PM, Heiko Schocher wrote:
> Hello Stephen,
> 
> Am 02.08.2013 23:43, schrieb Stephen Warren:
>> On 08/01/2013 10:40 PM, Heiko Schocher wrote:
>>> Am 01.08.2013 22:32, schrieb Stephen Warren:
>> ...
>>>> Given how long this discussion is going on, can we please just revert
>>>> the commit so that the code works for everyone who's trying to use it,
>>>> then fix the problem later?
>>>
>>> Yes, but not reverting the hole commit, please just remove the
>>> i2c_init_board() call in i2c_init_all() and test it, and send a
>>> new patch, thanks!
>>>
>>> diff --git a/drivers/i2c/i2c_core.c b/drivers/i2c/i2c_core.c
>>> index d1072e8..5f10eb3 100644
>>> --- a/drivers/i2c/i2c_core.c
>>> +++ b/drivers/i2c/i2c_core.c
>>> @@ -246,7 +246,6 @@ void i2c_init_board(void)
>>>    */
>>>   void i2c_init_all(void)
>>>   {
>>> -       i2c_init_board();
>>>          i2c_set_bus_num(CONFIG_SYS_SPD_BUS_NUM);
>>>          return;
>>>   }
>>
>> That change doesn't work. Instead of hanging immediately after printing
>> "I2C:", it hangs after printing:
>>
>> I2C:   Caller requested bad clock: periph=-49, parent=2
>>
>> I guess now various data is simply uninitialized since DT parsing hasn't
>> been run at all?
> 
> I do not know this ... and what happen if you make init_func_i2c()
> weak and default just dummy?
> 
>> This is exactly why I suggest a full revert of the problematic patch. If
>> we do that, it should immediately allow all Tegra boards to actually
>> work again. Right now, nobody can use or test u-boot.git/master is
> 
> nobody = only tegra boards ... I am working fine with current mainline
> on other arm targets ...

Sure, that is a valid distinction.

However, just because the problem doesn't affect all boards, that surely
doesn't make it any more acceptable?