From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 076F0C636D6 for ; Mon, 20 Feb 2023 17:59:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7094785918; Mon, 20 Feb 2023 18:58:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oSxgobYw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6D7948591F; Mon, 20 Feb 2023 18:58:57 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 96807858ED for ; Mon, 20 Feb 2023 18:58:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x835.google.com with SMTP id l12so1645092qtr.0 for ; Mon, 20 Feb 2023 09:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZqMvEGVqHss50GFcHLL/sblFwIgaKJowTO5bTR3VtDY=; b=oSxgobYwYepLmyidkzEvp1+A2+bCmXXXcb2yMgkN123QgVNb8/5sVxKNKBMfsIqQkf aRdjimXopEP1mQhHby5QA63lZvpKtMOaySf0Fr266rxfslHkfMqqgN5HxDukzMSRHHtE AOAGYQIh0zrxxzvyhAYMEydeRN7JZ6CkIVigTZf7yy8LUovM0S6un8JyDQ42VG3H9rWO q2nP8w+b8GRGdd6XXWvAz9J6fgynOEgYGbVcj5pZ/CfymgzAvBOoNZANocjL2Wb4KLWA sW0XrTAFQNlpu5p/DeGMu+L/jwT7VkNtU3kUKBzgP2s6KOY843pkK2P8PP+LugmgxUJP YKWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZqMvEGVqHss50GFcHLL/sblFwIgaKJowTO5bTR3VtDY=; b=5eqO7HSbiu5XiQ6BrLiSuOTpGAYlqnpbNGFcEdCIcuicG6WXcvRpnplxDPw9kggmuQ /htVYLJd/vo/LcGDP2GvMfSTUuu4Y2ZPCSLlErXtX5jLAqK+INYAjTOrZ9fJwq5w+2Zk nB5MXKqdmKzLuOaAyjimNpmBC/TaewOvdquZD/IVq4nNzaWBcI8DdzB8X8p4qAnZXzby syYnYXu63tF8RBLrcPWfp5+MStb6FhHSwHTm2MoyYj5hWVSAsA2SHVgFffCLE4RyzWku Qs3FtjwSSf0uxVuHpEfO/KHxqZNgRgJYOJThvrTgGqapgvcchzyXXYRIXoLoiOJ1AUD2 PAjQ== X-Gm-Message-State: AO0yUKVdPbCx1hJmloDolYRaqQV+3UM0tsIw72nSGxLv0t7+KZpzvW5L sBAwi0noMwKYbkFO9gbaSLo= X-Google-Smtp-Source: AK7set+1ZPcZepDD6olLzW19E+SywCDt3XY1kq1+Zt2vCQioKRhS+/OONIQAaaRy3rpJzhP4iXg0vQ== X-Received: by 2002:ac8:7d44:0:b0:3ba:1167:72d7 with SMTP id h4-20020ac87d44000000b003ba116772d7mr16605453qtb.61.1676915933341; Mon, 20 Feb 2023 09:58:53 -0800 (PST) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id a7-20020ac86107000000b003b6382f66b1sm9295877qtm.29.2023.02.20.09.58.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Feb 2023 09:58:52 -0800 (PST) Message-ID: <51dddf4c-10aa-ea61-a342-915adf192154@gmail.com> Date: Mon, 20 Feb 2023 12:58:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/6] clk: Fix error handling in clk_get_rate() Content-Language: en-US To: =?UTF-8?Q?Michal_Such=c3=a1nek?= Cc: Samuel Holland , Lukasz Majewski , Simon Glass , Dario Binacchi , Jean-Jacques Hiblot , Neil Armstrong , Peng Fan , u-boot@lists.denx.de References: <20230220055940.41890-1-samuel@sholland.org> <20230220055940.41890-3-samuel@sholland.org> <20230220103744.GH19419@kitsune.suse.cz> <3344084e-c3a4-4c56-9e17-cc7d38243ed8@gmail.com> <20230220172723.GM19419@kitsune.suse.cz> From: Sean Anderson In-Reply-To: <20230220172723.GM19419@kitsune.suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean T24gMi8yMC8yMyAxMjoyNywgTWljaGFsIFN1Y2jDoW5layB3cm90ZToNCj4gSGVsbG8sDQo+ IA0KPiBPbiBNb24sIEZlYiAyMCwgMjAyMyBhdCAxMTowODo0MUFNIC0wNTAwLCBTZWFuIEFu ZGVyc29uIHdyb3RlOg0KPj4gT24gMi8yMC8yMyAwNTozNywgTWljaGFsIFN1Y2jDoW5layB3 cm90ZToNCj4+PiBIZWxsbywNCj4+Pg0KPj4+IE9uIFN1biwgRmViIDE5LCAyMDIzIGF0IDEx OjU5OjM1UE0gLTA2MDAsIFNhbXVlbCBIb2xsYW5kIHdyb3RlOg0KPj4+PiBsb2dfcmV0KCkg Y2Fubm90IHdvcmsgd2l0aCB1bnNpZ25lZCB2YWx1ZXMsIGFuZCB0aGUgYXNzaWdubWVudCB0 byAncmV0Jw0KPj4+PiBpbmNvcnJlY3RseSB0cnVuY2F0ZXMgdGhlIHJhdGUgZnJvbSBsb25n IHRvIGludC4NCj4+Pj4NCj4+Pj4gRml4ZXM6IDVjNTk5MmNiOTBjZiAoImNsazogQWRkIGRl YnVnZ2luZyBmb3IgcmV0dXJuIHZhbHVlcyIpDQo+Pj4+IFNpZ25lZC1vZmYtYnk6IFNhbXVl bCBIb2xsYW5kIDxzYW11ZWxAc2hvbGxhbmQub3JnPg0KPj4+PiAtLS0NCj4+Pj4NCj4+Pj4g ICAgZHJpdmVycy9jbGsvY2xrLXVjbGFzcy5jIHwgNyArLS0tLS0tDQo+Pj4+ICAgIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNiBkZWxldGlvbnMoLSkNCj4+Pj4NCj4+Pj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL2Nsay11Y2xhc3MuYyBiL2RyaXZlcnMvY2xrL2Ns ay11Y2xhc3MuYw0KPj4+PiBpbmRleCBkYzNlOWQ2YTI2MS4uNzgyOTlkYmNlYjIgMTAwNjQ0 DQo+Pj4+IC0tLSBhL2RyaXZlcnMvY2xrL2Nsay11Y2xhc3MuYw0KPj4+PiArKysgYi9kcml2 ZXJzL2Nsay9jbGstdWNsYXNzLmMNCj4+Pj4gQEAgLTQ3MSw3ICs0NzEsNiBAQCB2b2lkIGNs a19mcmVlKHN0cnVjdCBjbGsgKmNsaykNCj4+Pj4gICAgdWxvbmcgY2xrX2dldF9yYXRlKHN0 cnVjdCBjbGsgKmNsaykNCj4+Pj4gICAgew0KPj4+PiAgICAJY29uc3Qgc3RydWN0IGNsa19v cHMgKm9wczsNCj4+Pj4gLQlpbnQgcmV0Ow0KPj4+PiAgICAJZGVidWcoIiVzKGNsaz0lcClc biIsIF9fZnVuY19fLCBjbGspOw0KPj4+PiAgICAJaWYgKCFjbGtfdmFsaWQoY2xrKSkNCj4+ Pj4gQEAgLTQ4MSwxMSArNDgwLDcgQEAgdWxvbmcgY2xrX2dldF9yYXRlKHN0cnVjdCBjbGsg KmNsaykNCj4+Pj4gICAgCWlmICghb3BzLT5nZXRfcmF0ZSkNCj4+Pj4gICAgCQlyZXR1cm4g LUVOT1NZUzsNCj4+Pj4gLQlyZXQgPSBvcHMtPmdldF9yYXRlKGNsayk7DQo+Pj4+IC0JaWYg KHJldCkNCj4+Pj4gLQkJcmV0dXJuIGxvZ19yZXQocmV0KTsNCj4+Pj4gLQ0KPj4+PiAtCXJl dHVybiAwOw0KPj4+PiArCXJldHVybiBvcHMtPmdldF9yYXRlKGNsayk7DQo+Pj4+ICAgIH0N Cj4+Pg0KPj4+IFRoaXMgaXMgZ2VuZXJhbGx5IHBvb3IgZGVzaWduIG9mIHRoZSBjbG9jayBz dHVmZiBpbiB1LWJvb3QuDQo+Pj4NCj4+PiBJdCByZXR1cm5zIC1FUlJPUiBmb3IgbWFueSBl cnJvciBjb25kaXRpb25zLCBidXQgYWxzbyAwIGZvciBvdGhlciBlcnJvcg0KPj4+IGNvbmRp dGlvbnMuDQo+Pj4NCj4+PiBTb21lIGVycm9yIGhhbmRsaW5nIGNoZWNrcyBmb3IgMCwgc29t ZSBmb3IgZXJydmFsLCBzb21lIGNhc3RzIHRvIGludCBhbmQNCj4+PiBjaGVja3MgZm9yIDw9 IDAuDQo+Pj4NCj4+PiBJIHRoaW5rIHRoYXQgdXNpbmcgLUVSUk9SIGZvciBjbG9ja3MgZG9l cyBub3QgbWFrZSBtdWNoIHNlbnNlIGluIHUtYm9vdC4NCj4+Pg0KPj4+IEV2ZW4gaW4gdGhl IGtlcm5lbCB0aGUgZXJydmFsIGNoZWNrcyBhcmUgcHJldHR5IG11Y2ggbGltaXRlZCB0byBw bGFjZXMNCj4+PiB3aGVyZSBpbnRlZ2VycyBhcmUgdXNlZCB0byBzdG9yZSBwYWdlIGZyYW1l IG51bWJlcnMgb3IgcG9pbnRlcnMsIHRoYXQgaXMNCj4+PiBlcnJwdHIgc3RvcmVkIGluIGFu IGludGVnZXIuIEZvciBhZHJlc3NlcyBpdCBpcyBwcmV0dHkgZWFzeSB0byBtYWtlIHN1cmUN Cj4+PiB0aGF0IHRoZSBsYXN0IHBhZ2UgaXMgbm90IG1hcHBlZCBtYWtpbmcgdGhlIGVycm9y IHBvaW50ZXJzIGludmFsaWQNCj4+PiAoYWx0aG91Z2ggYnVncyBpbiB0aGF0IHBhcnQgaGFw cGVuZWQgdG9vKS4NCj4+Pg0KPj4+IEZvciBjbG9ja3Mgbm8gc3VjaCBndWFyYW50ZWUgZXhp c3RzLiBUaGUgb25seSBhcHBhcmVudGx5IGludmFsaWQgY2xvY2sNCj4+PiBpcyAwLCBhbmQg dGhlIGNvcnJlY3QgZml4IGlzIHRvIGZpeCB1cCB0aGUgY2xvY2sgY29kZSB0byByZXR1cm4g MCBvbg0KPj4+IGVycm9yLCBhbHdheXMuIEl0J3MgYSBsb3Qgb2YgY29kZSB0byBmaXgsIHRo b3VnaC4NCj4+Pg0KPj4+IElmIHlvdSBkbyBub3Qgd2FudCB0byBmaXggZXZlcnl0aGluZyB0 aGVuIHRoZSBjb3JyZWN0IHRoaW5nIHRvIGRvIGlzDQo+Pj4gbWFrZSByZXQgdWxvbmcsIGFu ZCBjaGVjayBmb3IgZXJydmFsICphbmQqIDAuDQo+Pj4NCj4+PiBUaGVyZSBpcyBub3QgbXVj aCBwb2ludCBpbiByZXR1cm5pbmcgZGV0YWlsZWQgZXJyb3IgY29kZXMgaW4gdS1ib290LA0K Pj4+IGFueXdheS4gSXQncyBub3QgbGlrZSB0aGVyZSBpcyBzb21lIHVzZXJzcGFjZSB0aGF0 IGNvdWxkIGludGVycHJldCB0aGVtLg0KPj4+IE1vc3QgZXJyb3JzIGFyZSBsb2dnZWQgd2hl biB0aGV5IGhhcHBlbiBpZiBldmVyLCBhbmQgY2FsbGVycyBvbmx5IGNoZWNrDQo+Pj4gaWYg ZXJyb3IgaGFwcGVuZWQgb3Igbm90Lg0KPj4+DQo+Pj4gVGhhbmtzDQo+Pj4NCj4+PiBNaWNo YWwNCj4+DQo+PiBjbGtfZ2V0X3BhcmVudCBpcyB0aGUgb25seSBwbGFjZSB3aGVyZSB3ZSBy ZXR1cm4gYSBjbG9jayBwb2ludGVyIGRpcmVjdGx5Lg0KPj4gRXZlcnl3aGVyZSBlbHNlLCB3 ZSBoYXZlIGFuIGludGVnZXIgcmV0dXJuIHdlIGNhbiB1c2UuIFRoaXMgZnVuY3Rpb24gaXMN Cj4+IGRpZmZlcmVudCBvZiBjb3Vyc2UgYmVjYXVzZSBDQ0YgaXMgYnJva2VuIGFuZCBhc3N1 bWVzIHRoZXJlIGlzIG9ubHkgb25lDQo+PiBjYW5vbmljYWwgc3RydWN0IGNsayBmb3IgYSBs b2dpY2FsIGNsb2NrLiBTbyBpdCBjYW4ndCBpbml0aWFsaXplIGEgY2FsbGVyLXBhc3NlZA0K Pj4gc3RydWN0IGNsaywgYnV0IGluc3RlYWQgaGFzIHRvIHJldHVybiB0aGUgb25lIHRydWUg c3RydWN0IGNsay4NCj4+DQo+PiBJIGFncmVlIHdpdGggTWljaGFsIGhlcmUuIFRoZSBzaWdu YXR1cmUgc2hvdWxkIHJlYWxseSBiZQ0KPj4NCj4+IGludCBjbGtfZ2V0X3BhcmVudChzdHJ1 Y3QgY2xrICpjaGlsZCwgc3RydWN0IGNsayAqcGFyZW50KQ0KPj4NCj4+IGJ1dCBmb3Igbm93 IHRoZXJlIGlzIG5vIHBvaW50IGNvbmZ1c2luZyB0aGUgcmVzdCBvZiB0aGUgY2xvY2sgc3Vi c3lzdGVtIHRvIG1ha2UNCj4+IGl0IHdvcmsgd2l0aCBlcnJvciBwb2ludGVycy4NCj4gDQo+ IFRoaXMgaXMgY2xrX2dldF9yYXRlLg0KDQpBaCwgd2hvb3BzLiBJbiB0aGF0IGNhc2UsDQoN ClJldmlld2VkLWJ5OiBTZWFuIEFuZGVyc29uIDxzZWFuZ2EyQGdtYWlsLmNvbT4NCg0KPiBJ dCByZXR1cm5zIGEgY2xvY2sgcmF0ZS4gQSBjbG9jayByYXRlIG9mIDIuNUdIeiBpcw0KPiBu b3Qgb3V0IG9mIHF1ZXN0aW9uLCBhbmQgY2Fubm90IGJlIGV4cHJlc3NlZCB3aXRoIGEgc2ln bmVkIGludGVnZXIuDQoNCkFuZCBvZiBjb3Vyc2UgbmVpdGhlciBpcyBhIHJhdGUgb2YgNSBH SHogOikNCg0KPiBIZW5jZSBjbG9jayByYXRlIHNob3VsZCBub3QgYmUgdHJlYXRlZCBhcyBz aWduZWQsIGFuZCAtRVJST1Igc2hvdWxkIG5vdA0KPiBiZSByZXR1cm5lZCBhcyBjbG9jayBy YXRlLg0KDQpZZXMuLi4NCg0KSSB3b3VsZCBhY2NlcHQgYSBjb252ZXJzaW9uIHRvICIwIG1l YW5zIHVua25vd24gcmF0ZSAoZm9yIHdoYXRldmVyIHJlYXNvbikiIEFQSS4NCg0KLS1TZWFu DQo=