From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE95DC4332F for ; Tue, 29 Nov 2022 08:35:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 380C8830FA; Tue, 29 Nov 2022 09:35:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=yadro.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=yadro.com header.i=@yadro.com header.b="N1IZ9EUv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BAE5182F7F; Tue, 29 Nov 2022 09:35:21 +0100 (CET) Received: from mta-01.yadro.com (mta-02.yadro.com [89.207.88.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ED0D1830FA for ; Tue, 29 Nov 2022 09:35:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=yadro.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=v.v.mitrofanov@yadro.com Received: from localhost (unknown [127.0.0.1]) by mta-01.yadro.com (Postfix) with ESMTP id 81A5241247; Tue, 29 Nov 2022 08:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yadro.com; h= mime-version:content-type:content-type:content-language :accept-language:in-reply-to:references:message-id:date:date :subject:subject:from:from:received:received:received:received :received; s=mta-01; t=1669710915; x=1671525316; bh=vc7h/PZmnpaT AszsO0187o7vjZP/aTsmA7zDyLr+g+0=; b=N1IZ9EUvRANV7DinFhp1aB/7dRzu e0iy3jz1z8A1wofb6bhVO08Igx2JVnX9VmebaEx7l27jEt1adlnN77GYMt+JIvf4 8WSx/SpgBfrqNKy27K7bforjinps/vhBiSnirxv1/wwY3xe2je8s7eqEINtTB2xv 5BfLnCpLX+TxncI= Received: from mta-01.yadro.com ([127.0.0.1]) by localhost (mta-01.yadro.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qcDYZAvIg4wm; Tue, 29 Nov 2022 11:35:15 +0300 (MSK) Received: from T-EXCH-01.corp.yadro.com (T-EXCH-01.corp.yadro.com [172.17.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mta-01.yadro.com (Postfix) with ESMTPS id 7890941245; Tue, 29 Nov 2022 11:35:14 +0300 (MSK) Received: from T-EXCH-09.corp.yadro.com (172.17.11.59) by T-EXCH-01.corp.yadro.com (172.17.10.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.32; Tue, 29 Nov 2022 11:35:14 +0300 Received: from T-Exch-05.corp.yadro.com (172.17.10.109) by T-EXCH-09.corp.yadro.com (172.17.11.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.9; Tue, 29 Nov 2022 11:35:13 +0300 Received: from T-Exch-05.corp.yadro.com ([172.17.10.109]) by T-Exch-05.corp.yadro.com ([172.17.10.109]) with mapi id 15.02.1118.009; Tue, 29 Nov 2022 11:35:13 +0300 From: Vyacheslav Mitrofanov V To: Tom Rini CC: "rfried.dev@gmail.com" , "joe.hershberger@ni.com" , "wd@denx.de" , "u-boot@lists.denx.de" , "judge.packham@gmail.com" , "linux@yadro.com" , "sjg@chromium.org" Subject: Re: [PATCH v4 00/17] IPv6 support Thread-Topic: [PATCH v4 00/17] IPv6 support Thread-Index: AQHYw3prjOTamvvxJ0mZgcY61qk0Ca5UxLIAgAFOaAU= Date: Tue, 29 Nov 2022 08:35:13 +0000 Message-ID: <51ed934d189c4f89af2be9f6c28d4a88@yadro.com> References: <20220908115905.70928-1-v.v.mitrofanov@yadro.com>, <20221128153458.GT3787616@bill-the-cat> In-Reply-To: <20221128153458.GT3787616@bill-the-cat> Accept-Language: ru-RU, en-US Content-Language: ru-RU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.178.114.10] MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hello Tom! I tested this problem and I think it is necessary to set CONFIG_IPV6. Without that option tests fail. Thanks! ________________________________ =EF=D4: Tom Rini =EF=D4=D0=D2=C1=D7=CC=C5=CE=CF: 28 =CE=CF=D1=C2=D2=D1 2022 =C7. 18:34:58 =EB=CF=CD=D5: Vyacheslav Mitrofanov V =EB=CF=D0=C9=D1: rfried.dev@gmail.com; joe.hershberger@ni.com; wd@denx.de; = u-boot@lists.denx.de; judge.packham@gmail.com; linux@yadro.com; sjg@chromiu= m.org =F4=C5=CD=C1: Re: [PATCH v4 00/17] IPv6 support On Thu, Sep 08, 2022 at 02:58:48PM +0300, Viacheslav Mitrofanov wrote: > This patch set adds basic IPv6 support to U-boot. > It is based on Chris's Packham patches > (https://lists.denx.de/pipermail/u-boot/2017-January/279366.html) > Chris's patches were taken as base. There were efforts to launch it on > HiFive SiFive Unmatched board but the board didn't work well. The code wa= s > refactored, fixed some bugs as CRC for little-endian, some parts were imp= lemented in > our own way, something was taken from Linux. Finally we did manual tests = and the > board worked well. > > Testing was done on HiFive SiFive Unmatched board (RISC-V) > > Signed-off-by: Viacheslav Mitrofanov > --- > Changes in v2: > - Split big patches into smaller > - If an address in tftpboot is IPv6 than use IPv6 to boot > - Add tests > > Changes in v3: > - Added functions and structures description in whole patch-series > - Removed memory allocation in on_ip6addr() > - Some functions got return code from errno.h > - Add to string_to_ip6() length parameter to avoid obligatory null termi= nation > - Add a lot of small decorative cnages > > Changes in v4: > - Fixed funcs and structures style description > - Added omitted tags Testing this locally in sandbox I see: FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_csum_ipv6_magic] - A= ssertionError: as... FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_addr_in_subnet] = - AssertionError:... FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_make_lladdr] - a= ssert False FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_ip6_make_snma] - ass= ert False FAILED test/py/tests/test_ut.py::test_ut[ut_dm_dm_test_string_to_ip6] - Ass= ertionError: asse... and this happens in CI as well: https://source.denx.de/u-boot/u-boot/-/pipelines/14245 https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3D5432&view=3Dre= sults If you can't replicate the failures locally you should be able to trigger CI: https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html Thanks for pushing this along! -- Tom