From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Wed, 07 Aug 2013 00:19:39 +0530 Subject: [U-Boot] [PATCH 2/3] spi: fsl_espi: Use DIV_ROUND_UP instead of open-coded In-Reply-To: <1373622068.24016.4.camel@phoenix> References: <1373621981.24016.2.camel@phoenix> <1373622068.24016.4.camel@phoenix> Message-ID: <52014543.4020901@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12-07-2013 15:11, Axel Lin wrote: > Use DIV_ROUND_UP to simplify the code. > > Signed-off-by: Axel Lin > --- > drivers/spi/fsl_espi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c > index 28609ee..e20ab9f 100644 > --- a/drivers/spi/fsl_espi.c > +++ b/drivers/spi/fsl_espi.c > @@ -234,15 +234,13 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *data_out, > slave->bus, slave->cs, *(uint *) dout, > dout, *(uint *) din, din, len); > > - num_chunks = data_len / max_tran_len + > - (data_len % max_tran_len ? 1 : 0); > + num_chunks = DIV_ROUND_UP(data_len, max_tran_len); > while (num_chunks--) { > if (data_in) > din = buffer + rx_offset; > dout = buffer; > tran_len = min(data_len , max_tran_len); > - num_blks = (tran_len + cmd_len) / 4 + > - ((tran_len + cmd_len) % 4 ? 1 : 0); > + num_blks = DIV_ROUND_UP(tran_len + cmd_len, 4); > num_bytes = (tran_len + cmd_len) % 4; > fsl->data_len = tran_len + cmd_len; > spi_cs_activate(slave); > Reviewed-by: Jagannadha Sutradharudu Teki -- Thanks, Jagan.