From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Date: Wed, 07 Aug 2013 00:19:54 +0530 Subject: [U-Boot] [PATCH 3/3] spi: mpc8xxx_spi: Use DIV_ROUND_UP instead of open-coded In-Reply-To: <1373622135.24016.5.camel@phoenix> References: <1373621981.24016.2.camel@phoenix> <1373622135.24016.5.camel@phoenix> Message-ID: <52014552.30604@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12-07-2013 15:12, Axel Lin wrote: > Use DIV_ROUND_UP to simplify the code. > > Signed-off-by: Axel Lin > --- > drivers/spi/mpc8xxx_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c > index 6b0e3b4..c90c0ce 100644 > --- a/drivers/spi/mpc8xxx_spi.c > +++ b/drivers/spi/mpc8xxx_spi.c > @@ -93,7 +93,7 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout, > { > volatile spi8xxx_t *spi = &((immap_t *) (CONFIG_SYS_IMMR))->spi; > unsigned int tmpdout, tmpdin, event; > - int numBlks = bitlen / 32 + (bitlen % 32 ? 1 : 0); > + int numBlks = DIV_ROUND_UP(bitlen, 32); > int tm, isRead = 0; > unsigned char charSize = 32; > > Reviewed-by: Jagannadha Sutradharudu Teki -- Thanks, Jagan.