* [U-Boot] [PATCH] Fix for incorrect conversion hex string to number (FMAN firmware address).
@ 2013-06-19 7:48 Nikolay Puzanov
2013-08-09 0:30 ` [U-Boot] " York Sun
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Puzanov @ 2013-06-19 7:48 UTC (permalink / raw)
To: u-boot
---
arch/powerpc/cpu/mpc85xx/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
index 24eb978..ece1336 100644
--- a/arch/powerpc/cpu/mpc85xx/fdt.c
+++ b/arch/powerpc/cpu/mpc85xx/fdt.c
@@ -492,7 +492,7 @@ void fdt_fixup_fman_firmware(void *blob)
if (!p)
return;
- fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 0);
+ fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 16);
if (!fmanfw)
return;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] Fix for incorrect conversion hex string to number (FMAN firmware address).
2013-06-19 7:48 [U-Boot] [PATCH] Fix for incorrect conversion hex string to number (FMAN firmware address) Nikolay Puzanov
@ 2013-08-09 0:30 ` York Sun
2013-08-20 19:46 ` York Sun
0 siblings, 1 reply; 3+ messages in thread
From: York Sun @ 2013-08-09 0:30 UTC (permalink / raw)
To: u-boot
On 06/19/2013 12:48 AM, ??????? ??????? wrote:
> ---
> arch/powerpc/cpu/mpc85xx/fdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> ---
> 1.8.1.2
>
> diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
> index 24eb978..ece1336 100644
> --- a/arch/powerpc/cpu/mpc85xx/fdt.c
> +++ b/arch/powerpc/cpu/mpc85xx/fdt.c
> @@ -492,7 +492,7 @@ void fdt_fixup_fman_firmware(void *blob)
> if (!p)
> return;
>
> - fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 0);
> + fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 16);
> if (!fmanfw)
> return;
>
Andy,
I want to close on this patch. Is there any reason we shouldn't apply
this patch? Why don't we have a problem without it?
York
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] Fix for incorrect conversion hex string to number (FMAN firmware address).
2013-08-09 0:30 ` [U-Boot] " York Sun
@ 2013-08-20 19:46 ` York Sun
0 siblings, 0 replies; 3+ messages in thread
From: York Sun @ 2013-08-20 19:46 UTC (permalink / raw)
To: u-boot
On 08/08/2013 05:30 PM, York Sun wrote:
> On 06/19/2013 12:48 AM, ??????? ??????? wrote:
>> ---
>> arch/powerpc/cpu/mpc85xx/fdt.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> ---
>> 1.8.1.2
>>
>> diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
>> index 24eb978..ece1336 100644
>> --- a/arch/powerpc/cpu/mpc85xx/fdt.c
>> +++ b/arch/powerpc/cpu/mpc85xx/fdt.c
>> @@ -492,7 +492,7 @@ void fdt_fixup_fman_firmware(void *blob)
>> if (!p)
>> return;
>>
>> - fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 0);
>> + fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 16);
>> if (!fmanfw)
>> return;
>>
Applied to u-boot-mpc85xx/master, added sign-off-by line.
York
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-20 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-19 7:48 [U-Boot] [PATCH] Fix for incorrect conversion hex string to number (FMAN firmware address) Nikolay Puzanov
2013-08-09 0:30 ` [U-Boot] " York Sun
2013-08-20 19:46 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox