From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 9 Aug 2013 08:04:01 -0400 Subject: [U-Boot] : Suggestions for SPI driver pusher In-Reply-To: <5204ACE7.6080203@gmail.com> References: <5204ACE7.6080203@gmail.com> Message-ID: <5204DAB1.2010606@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/09/2013 04:48 AM, Jagan Teki wrote: > Hi, > > FYI: I am trying to prepare the spi driver code to more readable. > As each spi driver has a common set of calls. > > << header file inclusion >> << Register bit masks >> > > << MISC macro definitions >> > > << controller reg structure >> > > << controller private slave structure >> > > << inline func defination >> > > << spi_xfer_sub() >> > > << spi_setup_slave_sub >> > > << spi_cs_is_valid >> > > << spi_cs_activate >> > > << spi_cs_deactivate >> > > << spi_init >> > > << spi_setup_slave >> { spi_setup_slave_sub() } > > << spi_free_slave >> > > << spi_claim_bus >> > > << spi_release_bus >> > > << spi_xfer code >> { spi_xfer_sub() } > > I am just trying to do the above format at-least from the drivers > which are pushing now onwards. > > Please see the reff driver > http://git.denx.de/?p=u-boot/u-boot-spi.git;a=commitdiff;h=1465d055f9d7a81edacf30c9d20a1b51dfcbfa8d Sounds > > like a good idea to me. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSBNqxAAoJENk4IS6UOR1WFQ0P/RfYjz+GucnlBJHAlwJZCiRZ OImki6N+lMdYdQZKPJ93parZlWXcv+txSNxXhzDcpgKkm40nTYLlu606Ucw10yXW YcGm3IjBgT3d2/T3QcXgYD0wlfUCwOIyu0HpbfOG6VuFvd2XkePY1iVWObEMcREU xqr5bab0LM9QsPaggylYb7wm1oBy+SXrCJnVxKWqiMVTohI3LHNHqZgxMUoIxcba /pWEviQdQzwq4KROYZq6IDKUZfsATgnsWhxzhfy4CEMmmzdgPxYczvsSo5IcED37 SJ6m4luA664oUorU9VnJs66mRNz+3nreY+W7/QjqrgY7PiWMiKOt72qSPvbNiqWi VlCqBkqLTGs0T8THKN2E4JfzcYCBwD48+xItJpQ8ZrIWLRxHhI2pQXhx5Ov7qUsT iHbi/NZ/oyvTcdDfZ/Ohles1x5r+u/rI7Ya/Q+uKCg/kZnJHKlwgExLM9MlmXG6q Edhra+hNvWaWwFVXJE5/tfa0UQCJg9pLDM5mVCoSbaftpiCpemgt1/xIMGhfPSwj dwc+2iA2V8zIgJZVXoppGBmp2WJN46ztb81gcu+inYpaAPsYE8FIf8ilZa5gBHUl HKCijZ1wpQ4I2KkGMJhdlyIw3Nul1l9QH5Q3kMECZt8CeD1sfh+qBE0ULcgTJd8U g6VkFlFo5lHHDTke7RMZ =MMJh -----END PGP SIGNATURE-----