From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mateusz Zalega Date: Mon, 12 Aug 2013 11:33:33 +0200 Subject: [U-Boot] [RFC 01/10] New board-specific USB initialization interface In-Reply-To: <201308112004.51765.marex@denx.de> References: <1375786242-11734-1-git-send-email-m.zalega@samsung.com> <1375786242-11734-2-git-send-email-m.zalega@samsung.com> <201308112004.51765.marex@denx.de> Message-ID: <5208ABED.40808@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/11/13 20:04, Marek Vasut wrote: >> +/* You can initialize platform's USB host, device or both >> + * capabilities by passing this enum as an argument to >> + * board_usb_init(). >> + */ > > The comment style is wrong, please fix. Did the patchset pass checkpatch ? > > /* > * multi > * line > * comment > */ Yes, it did: ---8<--- $ ./tools/checkpatch.pl 0001-New-board-specific-USB-initialization-interface.patch total: 0 errors, 0 warnings, 0 checks, 154 lines checked NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE NETWORKING_BLOCK_COMMENT_STYLE USLEEP_RANGE 0001-New-board-specific-USB-initialization-interface.patch has no obvious style problems and is ready for submission. --->8--- NETWORKING_BLOCK_COMMENT_STYLE - ...and, in our case, this option is the culprit. Will fix. Thanks, -- Mateusz Zalega Samsung R&D Institute Poland (SRPOL) | Kernel and System Framework group