From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mugunthan V N Date: Mon, 12 Aug 2013 23:06:39 +0530 Subject: [U-Boot] [PATCH v3 1/4] arm, am33xx: add defines for gmii_sel_register bits In-Reply-To: <20130812142209.GF5164@bill-the-cat> References: <1375170837-18360-1-git-send-email-hs@denx.de> <1375170837-18360-2-git-send-email-hs@denx.de> <51F77C01.2050209@ti.com> <51F8ACAE.8000103@denx.de> <20130812142209.GF5164@bill-the-cat> Message-ID: <52091D27.4070806@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 12 August 2013 07:52 PM, Tom Rini wrote: >>>> +#define GMII2_SEL_MII 0x0 >>>> > >>+#define GMII2_SEL_RMII 0x4 >>>> > >>+#define GMII2_SEL_RGMII 0x8 >>>> > >>+#define GMII2_SEL_NOTUSED 0xc >>> > >NOTUSED not needed as it is not supposed to be used. >> > >> > same here ... > I think "Not Used" in the TRM here means "this port is not used" rather > than "this combination of bits is not to be used", so the changes are > correct. But having this define is not useful as far as I can think of as there is not abstraction API for this to check what user is passing. But I leave it to Tom's decision to have this change or not. Other than this the patch looks good to me. Acked-by: Mugunthan V N Regards Mugunthan V N