From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/2] powerpc: Use print_size() where appropriate
Date: Tue, 13 Aug 2013 14:26:01 -0700 [thread overview]
Message-ID: <520AA469.3060608@freescale.com> (raw)
In-Reply-To: <1375284665-6212-1-git-send-email-Shruti@Freescale.com>
On 07/31/2013 08:31 AM, Shruti Kanetkar wrote:
> Makes the startup output more consistent
>
> Signed-off-by: Shruti Kanetkar <Shruti@Freescale.com>
> Acked-by: Andy Fleming <afleming@freescale.com>
>
> ---
> arch/powerpc/cpu/mpc824x/cpu.c | 8 +++-----
> arch/powerpc/cpu/mpc85xx/cpu_init.c | 8 +++++---
> arch/powerpc/cpu/mpc8xx/cpu.c | 24 +++++++++++-------------
> arch/powerpc/cpu/mpc8xxx/ddr/main.c | 3 ++-
> 4 files changed, 21 insertions(+), 22 deletions(-)
>
>
> Hello PowerPC Custodians,
>
>
> These are two simple patches I've been playing with as part of my learning
> process. I realize that perhaps pieces of these patches should be submitted to
> their respective custodians, but given their simplicity I'm thinking one of the
> powerpc custodians can apply them (Andy perhaps) to their tree if nobody objects
>
> I compile-tested these patches on all the mpc8xx and mpc8[356]xxx powerpc
> boards/targets and I run them on one board each of the following families of
> SoC(s): MPC8xx, MPC83xx and MPC85xx
>
> Checkpatch has a few warnings like this:
>
> WARNING: space prohibited between function name and open parenthesis '('
> #132: FILE: arch/powerpc/cpu/ppc4xx/cpu.c:670:
> + printf (" 16 KiB I-Cache %d KiB D-Cache",
>
> but I simply preserved the existing formating/style in the respective files
>
Appreciate the cleanup. Please fix the space issue as checkpatch
complained. There are many examples of bad style in source code. We
should clean them up as much as we can. Thanks.
York
next prev parent reply other threads:[~2013-08-13 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 15:31 [U-Boot] [PATCH 1/2] powerpc: Use print_size() where appropriate Shruti Kanetkar
2013-07-31 15:31 ` [U-Boot] [PATCH 2/2] powerpc: Print hardcoded size like print_size() does Shruti Kanetkar
2013-08-20 18:16 ` York Sun
2013-08-13 21:26 ` York Sun [this message]
2013-08-20 18:16 ` [U-Boot] [PATCH 1/2] powerpc: Use print_size() where appropriate York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520AA469.3060608@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox