From: Mugunthan V N <mugunthanvnm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/4] arm, am33xx: add defines for gmii_sel_register bits
Date: Wed, 14 Aug 2013 11:59:33 +0530 [thread overview]
Message-ID: <520B23CD.4000203@ti.com> (raw)
In-Reply-To: <52091D27.4070806@ti.com>
On Monday 12 August 2013 11:06 PM, Mugunthan V N wrote:
> On Monday 12 August 2013 07:52 PM, Tom Rini wrote:
>>>>> +#define GMII2_SEL_MII 0x0
>>>>>>>> +#define GMII2_SEL_RMII 0x4
>>>>>>>> +#define GMII2_SEL_RGMII 0x8
>>>>>>>> +#define GMII2_SEL_NOTUSED 0xc
>>>>>> NOTUSED not needed as it is not supposed to be used.
>>>> same here ...
>> I think "Not Used" in the TRM here means "this port is not used" rather
>> than "this combination of bits is not to be used", so the changes are
>> correct.
> But having this define is not useful as far as I can think of as there
> is not abstraction API for this to check what user is passing. But I
> leave it to Tom's decision to have this change or not.
>
> Other than this the patch looks good to me.
> Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
>
>
I had a discussion with the hardware team internally and the comment is
*When these bits are set to 11b the RGMII is selected with internal
delay mode which was not timing closed. Therefore this register setting
is not supported so it should not be used. The respective pin
multiplexing should be used to deselect any unused CPGMAC pins.*c The
same will be updated in the TRM soon. So can you remove NOTUSED define
and resubmit the patch again and can include my Acked-by in your next
version patch.
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-08-14 6:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 7:53 [U-Boot] [PATCH v3 0/4] arm, am335x: add support for siemens boards Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 1/4] arm, am33xx: add defines for gmii_sel_register bits Heiko Schocher
2013-07-30 8:40 ` Mugunthan V N
2013-07-31 6:20 ` Heiko Schocher
2013-08-12 14:22 ` Tom Rini
2013-08-12 17:36 ` Mugunthan V N
2013-08-14 6:29 ` Mugunthan V N [this message]
2013-08-14 13:51 ` Tom Rini
2013-07-30 7:53 ` [U-Boot] [PATCH v3 2/4] arm, spl: add watchdog library to SPL Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 3/4] arm, am335x: add watchdog support Heiko Schocher
2013-07-30 7:53 ` [U-Boot] [PATCH v3 4/4] arm, am335x: add support for 3 siemens boards Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520B23CD.4000203@ti.com \
--to=mugunthanvnm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox