public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mxc_spi: bugfix for double incrementing read pointer on unaligned buffers in spi_xchg_single
@ 2013-08-14  8:06 Timo Herbrecher
  0 siblings, 0 replies; only message in thread
From: Timo Herbrecher @ 2013-08-14  8:06 UTC (permalink / raw)
  To: u-boot

If dout buffer is not 32 bit-aligned or data to transmit is not multiple
of 32 bit the read data pointer is already incremented on single byte reads.

Signed-off-by: Timo Herbrecher <t.herbrecher@gateware.de>
---
 drivers/spi/mxc_spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
index fd72a65..95dd03f 100644
--- a/drivers/spi/mxc_spi.c
+++ b/drivers/spi/mxc_spi.c
@@ -255,8 +255,8 @@ int spi_xchg_single(struct spi_slave *slave,
unsigned int bitlen,
                        } else {
                                data = *(u32 *)dout;
                                data = cpu_to_be32(data);
+                               dout += 4;
                        }
-                       dout += 4;
                }
                debug("Sending SPI 0x%x\n", data);
                reg_write(&regs->txdata, data);
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] only message in thread
only message in thread, other threads:[~2013-08-14  8:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-14  8:06 [U-Boot] [PATCH] mxc_spi: bugfix for double incrementing read pointer on unaligned buffers in spi_xchg_single Timo Herbrecher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox