From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX: Add documentation on how to use SPI NOR on MX28evk
Date: Wed, 14 Aug 2013 14:59:53 +0200 [thread overview]
Message-ID: <520B7F49.203@denx.de> (raw)
In-Reply-To: <CAC0tyxOQQbhY-EHy4dRhxP5MBcxoA2i219QOY_Cc8AQuWM6dng@mail.gmail.com>
Hi M?rten,
On 13/08/2013 17:48, M?rten Wikman wrote:
> 2013/8/11 Otavio Salvador <otavio@ossystems.com.br>:
>> On Sun, Aug 11, 2013 at 10:49 AM, M?rten Wikman <marten.wikman@novia.fi> wrote:
>>> This adds necessary information on how to use U-boot on SPI NOR on MX28evk
>>>
>>> Signed-off-by: Marten Wikman <marten.wikman@novia.fi>
>>
>> Marten,
>>
>> The patch looks right and complete; I'd just split it in two patches:
>>
>> - add the new target
>> - add documentation
>>
>> From your commit log it is not clear you're adding the new target.
>>
>> --
>> Otavio Salvador O.S. Systems
>> http://www.ossystems.com.br http://projetos.ossystems.com.br
>> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
>
> Should I split it into two and send is as PATCH v2 to the mailing list?
This is necessary - the two items documentation and new target are
orthogonal. Please do it in this way.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2013-08-14 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 13:49 [U-Boot] [PATCH] i.MX: Add documentation on how to use SPI NOR on MX28evk Mårten Wikman
2013-08-11 18:55 ` Otavio Salvador
2013-08-13 15:48 ` Mårten Wikman
2013-08-13 15:53 ` Otavio Salvador
2013-08-14 12:59 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520B7F49.203@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox