From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 14 Aug 2013 14:59:53 +0200 Subject: [U-Boot] [PATCH] i.MX: Add documentation on how to use SPI NOR on MX28evk In-Reply-To: References: Message-ID: <520B7F49.203@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi M?rten, On 13/08/2013 17:48, M?rten Wikman wrote: > 2013/8/11 Otavio Salvador : >> On Sun, Aug 11, 2013 at 10:49 AM, M?rten Wikman wrote: >>> This adds necessary information on how to use U-boot on SPI NOR on MX28evk >>> >>> Signed-off-by: Marten Wikman >> >> Marten, >> >> The patch looks right and complete; I'd just split it in two patches: >> >> - add the new target >> - add documentation >> >> From your commit log it is not clear you're adding the new target. >> >> -- >> Otavio Salvador O.S. Systems >> http://www.ossystems.com.br http://projetos.ossystems.com.br >> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 > > Should I split it into two and send is as PATCH v2 to the mailing list? This is necessary - the two items documentation and new target are orthogonal. Please do it in this way. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================