public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] RFC: tegra: Avoid using I2C prior to relocation
Date: Wed, 14 Aug 2013 09:59:08 -0600	[thread overview]
Message-ID: <520BA94C.20009@wwwdotorg.org> (raw)
In-Reply-To: <20130813211251.GJ18706@bill-the-cat>

On 08/13/2013 03:12 PM, Tom Rini wrote:
> On Wed, Aug 07, 2013 at 10:20:01AM -0600, Stephen Warren wrote:
>> On 08/06/2013 11:52 PM, Simon Glass wrote:
>>> Tegra recently moved to the new I2C framework, which sets up
>>> I2C prior to relocation, and prior to calling i2c_init_board().
>>> This causes a crash on Tegra boards.
>>> 
>>> note:
>>> 
>>> There are many ways to fix this. I believe this is one. It
>>> disables i2c_init() until relocation is complete. I have been
>>> unable to test it so far due to problems getting my Seaboard to
>>> work. I will try another Tegra board, but send this for comment
>>> in the meantime.
>> 
>> Tested-by: Stephen Warren <swarren@nvidia.com>
> 
> With a hand-tweaked commit message, applied to u-boot/master,
> thanks!

Thanks!

For the record, I tested u-boot.git/master commit:

cdce889 tegra: Avoid using I2C prior to relocation

on Beaver, and booted a kernel both from SD card and over USB
Ethernet, and both cases worked fine. So, we have a known-good commit
for any future bisects:-)

  reply	other threads:[~2013-08-14 15:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07  5:52 [U-Boot] [PATCH] RFC: tegra: Avoid using I2C prior to relocation Simon Glass
2013-08-07 16:20 ` Stephen Warren
2013-08-07 21:03   ` Simon Glass
2013-08-09 23:17   ` Stephen Warren
2013-08-10  4:03     ` Simon Glass
2013-08-11  1:21       ` Tom Warren
2013-08-13 19:34         ` Simon Glass
2013-08-13 19:42           ` Stephen Warren
2013-08-13 21:12   ` Tom Rini
2013-08-14 15:59     ` Stephen Warren [this message]
2013-08-14 16:02       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520BA94C.20009@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox