public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] powerpc: Fix CamelCase checkpatch warnings
@ 2013-08-16  7:26 Prabhakar Kushwaha
  2013-08-16  8:53 ` thomas.langer at lantiq.com
  0 siblings, 1 reply; 3+ messages in thread
From: Prabhakar Kushwaha @ 2013-08-16  7:26 UTC (permalink / raw)
  To: u-boot

85xx, 86xx PowerPC folders have code variables with CamelCase naming conventions.
because of this code checkpatch script generates "WARNING: Avoid CamelCase".

This patch set Convert variables name to normal naming convention and modify
board, driver files with updated new
  - [PATCH 1/2] powerpc: Fix CamelCase checkpatch warnings
  - [PATCH 2/2] board: Update variable names as per new the structures

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] powerpc: Fix CamelCase checkpatch warnings
  2013-08-16  7:26 [U-Boot] [PATCH] powerpc: Fix CamelCase checkpatch warnings Prabhakar Kushwaha
@ 2013-08-16  8:53 ` thomas.langer at lantiq.com
  2013-08-16  9:13   ` Prabhakar Kushwaha
  0 siblings, 1 reply; 3+ messages in thread
From: thomas.langer at lantiq.com @ 2013-08-16  8:53 UTC (permalink / raw)
  To: u-boot

Hello Prabhakar,

Prabhakar Kushwaha wrote on?2013-08-16:
> 85xx, 86xx PowerPC folders have code variables with CamelCase naming
> conventions. because of this code checkpatch script generates "WARNING:
> Avoid CamelCase".
> 
> This patch set Convert variables name to normal naming convention and
> modify board, driver files with updated new
>   - [PATCH 1/2] powerpc: Fix CamelCase checkpatch warnings
>   - [PATCH 2/2] board: Update variable names as per new the structures
> 
I think you have to fold both patches together to have the change bisectable!
Otherwise your board code will not compile after applying only the first patch.

Best Regards,
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] powerpc: Fix CamelCase checkpatch warnings
  2013-08-16  8:53 ` thomas.langer at lantiq.com
@ 2013-08-16  9:13   ` Prabhakar Kushwaha
  0 siblings, 0 replies; 3+ messages in thread
From: Prabhakar Kushwaha @ 2013-08-16  9:13 UTC (permalink / raw)
  To: u-boot

On 08/16/2013 02:23 PM, thomas.langer at lantiq.com wrote:
> Hello Prabhakar,
>
> Prabhakar Kushwaha wrote on 2013-08-16:
>> 85xx, 86xx PowerPC folders have code variables with CamelCase naming
>> conventions. because of this code checkpatch script generates "WARNING:
>> Avoid CamelCase".
>>
>> This patch set Convert variables name to normal naming convention and
>> modify board, driver files with updated new
>>    - [PATCH 1/2] powerpc: Fix CamelCase checkpatch warnings
>>    - [PATCH 2/2] board: Update variable names as per new the structures
>>
> I think you have to fold both patches together to have the change bisectable!
> Otherwise your board code will not compile after applying only the first patch.
>
>

Thanks Thomas,
I will merge both the patches.

Regards,
Prabhakar

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-16  9:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-16  7:26 [U-Boot] [PATCH] powerpc: Fix CamelCase checkpatch warnings Prabhakar Kushwaha
2013-08-16  8:53 ` thomas.langer at lantiq.com
2013-08-16  9:13   ` Prabhakar Kushwaha

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox