[U-Boot] [PATCH] Origen: Set FIMD as the default display path

[U-Boot] [PATCH] Origen: Set FIMD as the default display path

[Tushar Behera]

On EXYNOS4210, there are three paths for display data to be processed,
namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
is used.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
This patch is rebased on master branch of u-boot-samsung tree.

 board/samsung/origen/lowlevel_init.S |   13 +++++++++++++
 board/samsung/origen/origen_setup.h  |    7 +++++++
 2 files changed, 20 insertions(+)

diff --git a/board/samsung/origen/lowlevel_init.S b/board/samsung/origen/lowlevel_init.S
index be9d418..a7ea680 100644
--- a/board/samsung/origen/lowlevel_init.S
+++ b/board/samsung/origen/lowlevel_init.S
@@ -89,6 +89,7 @@ lowlevel_init:
 	bl uart_asm_init
 	bl arch_cpu_init
 	bl tzpc_init
+	bl display_init
 	pop	{pc}
 
 wakeup_reset:
@@ -96,6 +97,7 @@ wakeup_reset:
 	bl mem_ctrl_asm_init
 	bl arch_cpu_init
 	bl tzpc_init
+	bl display_init
 
 exit_wakeup:
 	/* Load return address and jump to kernel */
@@ -355,3 +357,14 @@ uart_asm_init:
 	nop
 	nop
 
+/* Setting default display path to FIMD */
+display_init:
+	push	{lr}
+	ldr	r0, =EXYNOS4_SYSREG_BASE
+
+	/* DISPLAY_CONTROL */
+	ldr	r1, =DISPLAY_CONTROL_VAL
+	ldr	r2, =DISPLAY_CONTROL_OFFSET
+	str	r1, [r0, r2]
+
+	pop	{pc}
diff --git a/board/samsung/origen/origen_setup.h b/board/samsung/origen/origen_setup.h
index 926a4cc..b0e1bc2 100644
--- a/board/samsung/origen/origen_setup.h
+++ b/board/samsung/origen/origen_setup.h
@@ -83,6 +83,8 @@
 #define VPLL_CON0_OFFSET	0xC120
 #define VPLL_CON1_OFFSET	0xC124
 
+#define DISPLAY_CONTROL_OFFSET	0x210
+
 /* DMC: DRAM Controllor Register offsets */
 #define DMC_CONCONTROL		0x00
 #define DMC_MEMCONTROL		0x04
@@ -485,6 +487,11 @@
 				| (VPLL_MRR << 24) \
 				| (VPLL_MFR << 16) \
 				| (VPLL_K << 0))
+
+/* DISPLAY_CONTROL */
+#define FIMDBYPASS_LBLK0	0x1
+#define DISPLAY_CONTROL_VAL	(FIMDBYPASS_LBLK0 << 1)
+
 /*
  * UART GPIO_A0/GPIO_A1 Control Register Value
  * 0x2: UART Function
-- 
1.7.9.5

[U-Boot] [PATCH] Origen: Set FIMD as the default display path

[Tushar Behera]

On EXYNOS4210, there are three paths for display data to be processed,
namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
is used.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
This patch is rebased on master branch of u-boot-samsung tree.

 board/samsung/origen/lowlevel_init.S |   13 +++++++++++++
 board/samsung/origen/origen_setup.h  |    7 +++++++
 2 files changed, 20 insertions(+)

diff --git a/board/samsung/origen/lowlevel_init.S b/board/samsung/origen/lowlevel_init.S
index be9d418..a7ea680 100644
--- a/board/samsung/origen/lowlevel_init.S
+++ b/board/samsung/origen/lowlevel_init.S
@@ -89,6 +89,7 @@ lowlevel_init:
 	bl uart_asm_init
 	bl arch_cpu_init
 	bl tzpc_init
+	bl display_init
 	pop	{pc}
 
 wakeup_reset:
@@ -96,6 +97,7 @@ wakeup_reset:
 	bl mem_ctrl_asm_init
 	bl arch_cpu_init
 	bl tzpc_init
+	bl display_init
 
 exit_wakeup:
 	/* Load return address and jump to kernel */
@@ -355,3 +357,14 @@ uart_asm_init:
 	nop
 	nop
 
+/* Setting default display path to FIMD */
+display_init:
+	push	{lr}
+	ldr	r0, =EXYNOS4_SYSREG_BASE
+
+	/* DISPLAY_CONTROL */
+	ldr	r1, =DISPLAY_CONTROL_VAL
+	ldr	r2, =DISPLAY_CONTROL_OFFSET
+	str	r1, [r0, r2]
+
+	pop	{pc}
diff --git a/board/samsung/origen/origen_setup.h b/board/samsung/origen/origen_setup.h
index 926a4cc..b0e1bc2 100644
--- a/board/samsung/origen/origen_setup.h
+++ b/board/samsung/origen/origen_setup.h
@@ -83,6 +83,8 @@
 #define VPLL_CON0_OFFSET	0xC120
 #define VPLL_CON1_OFFSET	0xC124
 
+#define DISPLAY_CONTROL_OFFSET	0x210
+
 /* DMC: DRAM Controllor Register offsets */
 #define DMC_CONCONTROL		0x00
 #define DMC_MEMCONTROL		0x04
@@ -485,6 +487,11 @@
 				| (VPLL_MRR << 24) \
 				| (VPLL_MFR << 16) \
 				| (VPLL_K << 0))
+
+/* DISPLAY_CONTROL */
+#define FIMDBYPASS_LBLK0	0x1
+#define DISPLAY_CONTROL_VAL	(FIMDBYPASS_LBLK0 << 1)
+
 /*
  * UART GPIO_A0/GPIO_A1 Control Register Value
  * 0x2: UART Function
-- 
1.7.9.5

[U-Boot] [PATCH] Origen: Set FIMD as the default display path

[Minkyu Kang]

Dear Tushar Behera,

On 07/06/13 19:56, Tushar Behera wrote:
> On EXYNOS4210, there are three paths for display data to be processed,
> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
> is used.
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> This patch is rebased on master branch of u-boot-samsung tree.
> 
>  board/samsung/origen/lowlevel_init.S |   13 +++++++++++++
>  board/samsung/origen/origen_setup.h  |    7 +++++++
>  2 files changed, 20 insertions(+)
> 

Since the lowlevel_init.S is removed, this patch cannot be applied.

Thanks,
Minkyu Kang.

[U-Boot] [PATCH] Origen: Set FIMD as the default display path

[Tushar Behera]

On 08/06/2013 08:29 AM, Minkyu Kang wrote:
> Dear Tushar Behera,
> 
> On 07/06/13 19:56, Tushar Behera wrote:
>> On EXYNOS4210, there are three paths for display data to be processed,
>> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>> is used.
>>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>> This patch is rebased on master branch of u-boot-samsung tree.
>>
>>  board/samsung/origen/lowlevel_init.S |   13 +++++++++++++
>>  board/samsung/origen/origen_setup.h  |    7 +++++++
>>  2 files changed, 20 insertions(+)
>>
> 
> Since the lowlevel_init.S is removed, this patch cannot be applied.
> 

I will rebase to current tip and send again.

> Thanks,
> Minkyu Kang.
> 

Thanks.
-- 
Tushar Behera

[U-Boot] [PATCH] Origen: Set FIMD as the default display path

[Ajay kumar]

+Donghwa Lee


Hi Tushar,

I think this setting already exists for Exynos4 in u-boot.

Are you not getting display without your patch?

Have a look at this:
http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/exynos/system.c;h=ad12445832cf7415e52e8593b595ab33a0b4d375;hb=HEAD#l33


Regards,
Ajay Kumar


On Tue, Aug 6, 2013 at 12:07 PM, Tushar Behera <tushar.behera@linaro.org>wrote:

> On 08/06/2013 08:29 AM, Minkyu Kang wrote:
> > Dear Tushar Behera,
> >
> > On 07/06/13 19:56, Tushar Behera wrote:
> >> On EXYNOS4210, there are three paths for display data to be processed,
> >> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
> >> is used.
> >>
> >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> >> ---
> >> This patch is rebased on master branch of u-boot-samsung tree.
> >>
> >>  board/samsung/origen/lowlevel_init.S |   13 +++++++++++++
> >>  board/samsung/origen/origen_setup.h  |    7 +++++++
> >>  2 files changed, 20 insertions(+)
> >>
> >
> > Since the lowlevel_init.S is removed, this patch cannot be applied.
> >
>
> I will rebase to current tip and send again.
>
> > Thanks,
> > Minkyu Kang.
> >
>
> Thanks.
> --
> Tushar Behera
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] [PATCH] Origen: Set FIMD as the default display path

[Tushar Behera]

On 6 August 2013 14:21, Ajay kumar <ajaynumb@gmail.com> wrote:
> +Donghwa Lee
>
>
> Hi Tushar,
>
> I think this setting already exists for Exynos4 in u-boot.
>

No, there was no display on Origen board without this patch.

> Are you not getting display without your patch?
>
> Have a look at this:
> http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/exynos/system.c;h=ad12445832cf7415e52e8593b595ab33a0b4d375;hb=HEAD#l33
>

Thanks for the pointer. Let me check if I am missing anything for
Origen u-boot code.

-- 
Tushar Behera

[U-Boot] [PATCH] Origen: Set FIMD as the default display path

[Tushar Behera]

On 6 August 2013 16:10, Tushar Behera <tushar.behera@linaro.org> wrote:
> On 6 August 2013 14:21, Ajay kumar <ajaynumb@gmail.com> wrote:
>> +Donghwa Lee
>>
>>
>> Hi Tushar,
>>
>> I think this setting already exists for Exynos4 in u-boot.
>>
>
> No, there was no display on Origen board without this patch.
>
>> Are you not getting display without your patch?
>>
>> Have a look at this:
>> http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=arch/arm/cpu/armv7/exynos/system.c;h=ad12445832cf7415e52e8593b595ab33a0b4d375;hb=HEAD#l33
>>
>
> Thanks for the pointer. Let me check if I am missing anything for
> Origen u-boot code.
>

This code is called if CONFIG_LCD is enabled. Calling
set_system_display_ctrl() from Origen board_init() fixes my problem.

Thanks.
-- 
Tushar Behera

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Tushar Behera]

On EXYNOS4210, there are three paths for display data to be processed,
namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
is used.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
Changes for V2:
* Updated review comments from Ajay Kumar, reusing the code from
arch/arm/cpu/armv7/exynos/system.c.

 board/samsung/origen/origen.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
index 15f77ca..bb16699 100644
--- a/board/samsung/origen/origen.c
+++ b/board/samsung/origen/origen.c
@@ -22,6 +22,9 @@ int board_init(void)
 	gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
 
 	gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
+
+	set_system_display_ctrl();
+
 	return 0;
 }
 
-- 
1.7.9.5

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Ajay kumar]

On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera@linaro.org>wrote:

> On EXYNOS4210, there are three paths for display data to be processed,
> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
> is used.
>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> Changes for V2:
> * Updated review comments from Ajay Kumar, reusing the code from
> arch/arm/cpu/armv7/exynos/system.c.
>
>  board/samsung/origen/origen.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
> index 15f77ca..bb16699 100644
> --- a/board/samsung/origen/origen.c
> +++ b/board/samsung/origen/origen.c
> @@ -22,6 +22,9 @@ int board_init(void)
>         gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>
>         gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
> +
> +       set_system_display_ctrl();
> +
>
Ok. You are trying to get the display up in the kernel,
without enabling the display in u-boot.
And, thats why you are making an explicit call here?

        return 0;
>  }
>
> --
> 1.7.9.5
>
>

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Donghwa Lee]

On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote:
> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera at linaro.org <mailto:tushar.behera@linaro.org>> wrote:
>
>     On EXYNOS4210, there are three paths for display data to be processed,
>     namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>     is used.
>
>     Signed-off-by: Tushar Behera <tushar.behera at linaro.org <mailto:tushar.behera@linaro.org>>
>     ---
>     Changes for V2:
>     * Updated review comments from Ajay Kumar, reusing the code from
>     arch/arm/cpu/armv7/exynos/system.c.
>
>      board/samsung/origen/origen.c |    3 +++
>      1 file changed, 3 insertions(+)
>
>     diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
>     index 15f77ca..bb16699 100644
>     --- a/board/samsung/origen/origen.c
>     +++ b/board/samsung/origen/origen.c
>     @@ -22,6 +22,9 @@ int board_init(void)
>             gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>
>             gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
>     +
>     +       set_system_display_ctrl();
>     +
>
> Ok. You are trying to get the display up in the kernel,
> without enabling the display in u-boot.
> And, thats why you are making an explicit call here?
>
Previously, Ajay kumar said set_system_display_ctrl() function is already called by
lcd_ctrl_init() of exynos_fb.c.
If you need to use FIMD path, you'd better use the existing one.
>
>             return 0;
>      }
>
>     --
>     1.7.9.5
>
>

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Tushar Behera]

On 19 August 2013 07:22, Donghwa Lee <dh09.lee@samsung.com> wrote:
> On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote:
>
> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera@linaro.org>
> wrote:
>>
>> On EXYNOS4210, there are three paths for display data to be processed,
>> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>> is used.
>>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>> Changes for V2:
>> * Updated review comments from Ajay Kumar, reusing the code from
>> arch/arm/cpu/armv7/exynos/system.c.
>>
>>  board/samsung/origen/origen.c |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
>> index 15f77ca..bb16699 100644
>> --- a/board/samsung/origen/origen.c
>> +++ b/board/samsung/origen/origen.c
>> @@ -22,6 +22,9 @@ int board_init(void)
>>         gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>>
>>         gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
>> +
>> +       set_system_display_ctrl();
>> +
>
> Ok. You are trying to get the display up in the kernel,
> without enabling the display in u-boot.
> And, thats why you are making an explicit call here?
>

Yes, as of now, I don't want LCD support in u-boot, but I want to just
enable the display path.

> Previously, Ajay kumar said set_system_display_ctrl() function is already
> called by
> lcd_ctrl_init() of exynos_fb.c.
> If you need to use FIMD path, you'd better use the existing one.

I tried enabling CONFIG_LCD and related config options so that
existing display path in u-boot is called. That somehow stalls the
u-boot and I didn't want to pursue that much as calling this function
fixes my issue.

>>
>>         return 0;
>>  }
>>
>> --
>> 1.7.9.5
>>
>
>



-- 
Tushar Behera

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Donghwa Lee]

On 2013? 08? 19? 12:06, Tushar Behera wrote:
> On 19 August 2013 07:22, Donghwa Lee <dh09.lee@samsung.com> wrote:
>> On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote:
>>
>> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera@linaro.org>
>> wrote:
>>> On EXYNOS4210, there are three paths for display data to be processed,
>>> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>>> is used.
>>>
>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>> ---
>>> Changes for V2:
>>> * Updated review comments from Ajay Kumar, reusing the code from
>>> arch/arm/cpu/armv7/exynos/system.c.
>>>
>>>  board/samsung/origen/origen.c |    3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
>>> index 15f77ca..bb16699 100644
>>> --- a/board/samsung/origen/origen.c
>>> +++ b/board/samsung/origen/origen.c
>>> @@ -22,6 +22,9 @@ int board_init(void)
>>>         gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>>>
>>>         gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
>>> +
>>> +       set_system_display_ctrl();
>>> +
>> Ok. You are trying to get the display up in the kernel,
>> without enabling the display in u-boot.
>> And, thats why you are making an explicit call here?
>>
> Yes, as of now, I don't want LCD support in u-boot, but I want to just
> enable the display path.
>

If you don't need to LCD support in u-boot, which case do you need to enable the display path to FIMD?

>> Previously, Ajay kumar said set_system_display_ctrl() function is already
>> called by
>> lcd_ctrl_init() of exynos_fb.c.
>> If you need to use FIMD path, you'd better use the existing one.
> I tried enabling CONFIG_LCD and related config options so that
> existing display path in u-boot is called. That somehow stalls the
> u-boot and I didn't want to pursue that much as calling this function
> fixes my issue.
>
>>>         return 0;
>>>  }
>>>
>>> --
>>> 1.7.9.5
>>>
>>
>
>

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Tushar Behera]

On 19 August 2013 10:01, Donghwa Lee <dh09.lee@samsung.com> wrote:
> On 2013? 08? 19? 12:06, Tushar Behera wrote:
>> On 19 August 2013 07:22, Donghwa Lee <dh09.lee@samsung.com> wrote:
>>> On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote:
>>>
>>> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera@linaro.org>
>>> wrote:
>>>> On EXYNOS4210, there are three paths for display data to be processed,
>>>> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>>>> is used.
>>>>
>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>> ---
>>>> Changes for V2:
>>>> * Updated review comments from Ajay Kumar, reusing the code from
>>>> arch/arm/cpu/armv7/exynos/system.c.
>>>>
>>>>  board/samsung/origen/origen.c |    3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
>>>> index 15f77ca..bb16699 100644
>>>> --- a/board/samsung/origen/origen.c
>>>> +++ b/board/samsung/origen/origen.c
>>>> @@ -22,6 +22,9 @@ int board_init(void)
>>>>         gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>>>>
>>>>         gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
>>>> +
>>>> +       set_system_display_ctrl();
>>>> +
>>> Ok. You are trying to get the display up in the kernel,
>>> without enabling the display in u-boot.
>>> And, thats why you are making an explicit call here?
>>>
>> Yes, as of now, I don't want LCD support in u-boot, but I want to just
>> enable the display path.
>>
>
> If you don't need to LCD support in u-boot, which case do you need to enable the display path to FIMD?
>

This modification is essential for enabling LCD support in kernel.
While working with DT kernel, we couldn't any suitable place in kernel
where we can place this code. That is the reason why we thought of
having this bit setup in u-boot.

>>> Previously, Ajay kumar said set_system_display_ctrl() function is already
>>> called by
>>> lcd_ctrl_init() of exynos_fb.c.
>>> If you need to use FIMD path, you'd better use the existing one.
>> I tried enabling CONFIG_LCD and related config options so that
>> existing display path in u-boot is called. That somehow stalls the
>> u-boot and I didn't want to pursue that much as calling this function
>> fixes my issue.
>>
>>>>         return 0;
>>>>  }
>>>>
>>>> --
>>>> 1.7.9.5
>>>>
>>>
>>
>>
>



-- 
Tushar Behera

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Tushar Behera]

On 19 August 2013 11:30, Tushar Behera <tushar.behera@linaro.org> wrote:
> On 19 August 2013 10:01, Donghwa Lee <dh09.lee@samsung.com> wrote:
>> On 2013? 08? 19? 12:06, Tushar Behera wrote:
>>> On 19 August 2013 07:22, Donghwa Lee <dh09.lee@samsung.com> wrote:
>>>> On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote:
>>>>
>>>> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera@linaro.org>
>>>> wrote:
>>>>> On EXYNOS4210, there are three paths for display data to be processed,
>>>>> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>>>>> is used.
>>>>>
>>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>>> ---
>>>>> Changes for V2:
>>>>> * Updated review comments from Ajay Kumar, reusing the code from
>>>>> arch/arm/cpu/armv7/exynos/system.c.
>>>>>
>>>>>  board/samsung/origen/origen.c |    3 +++
>>>>>  1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
>>>>> index 15f77ca..bb16699 100644
>>>>> --- a/board/samsung/origen/origen.c
>>>>> +++ b/board/samsung/origen/origen.c
>>>>> @@ -22,6 +22,9 @@ int board_init(void)
>>>>>         gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>>>>>
>>>>>         gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
>>>>> +
>>>>> +       set_system_display_ctrl();
>>>>> +
>>>> Ok. You are trying to get the display up in the kernel,
>>>> without enabling the display in u-boot.
>>>> And, thats why you are making an explicit call here?
>>>>
>>> Yes, as of now, I don't want LCD support in u-boot, but I want to just
>>> enable the display path.
>>>
>>
>> If you don't need to LCD support in u-boot, which case do you need to enable the display path to FIMD?
>>
>
> This modification is essential for enabling LCD support in kernel.
> While working with DT kernel, we couldn't any suitable place in kernel
> where we can place this code. That is the reason why we thought of
> having this bit setup in u-boot.
>

Can we go ahead with this patch?

-- 
Tushar Behera

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Minkyu Kang]

On 28/08/13 20:47, Tushar Behera wrote:
> On 19 August 2013 11:30, Tushar Behera <tushar.behera@linaro.org> wrote:
>> On 19 August 2013 10:01, Donghwa Lee <dh09.lee@samsung.com> wrote:
>>> On 2013? 08? 19? 12:06, Tushar Behera wrote:
>>>> On 19 August 2013 07:22, Donghwa Lee <dh09.lee@samsung.com> wrote:
>>>>> On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote:
>>>>>
>>>>> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera@linaro.org>
>>>>> wrote:
>>>>>> On EXYNOS4210, there are three paths for display data to be processed,
>>>>>> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>>>>>> is used.
>>>>>>
>>>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>>>> ---
>>>>>> Changes for V2:
>>>>>> * Updated review comments from Ajay Kumar, reusing the code from
>>>>>> arch/arm/cpu/armv7/exynos/system.c.
>>>>>>
>>>>>>  board/samsung/origen/origen.c |    3 +++
>>>>>>  1 file changed, 3 insertions(+)
>>>>>>
>>>>>> diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
>>>>>> index 15f77ca..bb16699 100644
>>>>>> --- a/board/samsung/origen/origen.c
>>>>>> +++ b/board/samsung/origen/origen.c
>>>>>> @@ -22,6 +22,9 @@ int board_init(void)
>>>>>>         gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>>>>>>
>>>>>>         gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
>>>>>> +
>>>>>> +       set_system_display_ctrl();
>>>>>> +
>>>>> Ok. You are trying to get the display up in the kernel,
>>>>> without enabling the display in u-boot.
>>>>> And, thats why you are making an explicit call here?
>>>>>
>>>> Yes, as of now, I don't want LCD support in u-boot, but I want to just
>>>> enable the display path.
>>>>
>>>
>>> If you don't need to LCD support in u-boot, which case do you need to enable the display path to FIMD?
>>>
>>
>> This modification is essential for enabling LCD support in kernel.
>> While working with DT kernel, we couldn't any suitable place in kernel
>> where we can place this code. That is the reason why we thought of
>> having this bit setup in u-boot.
>>

I understood your concept.
but I feel, it's a workaround.

you said.
"
I tried enabling CONFIG_LCD and related config options so that
existing display path in u-boot is called. That somehow stalls the
u-boot and I didn't want to pursue that much as calling this function
fixes my issue.
"

Why don't you try to find the reason why stalls the u-boot.

Thanks,
Minkyu Kang.

[U-Boot] [PATCH V2] Origen: Set FIMD as the default display path

[Tushar Behera]

On 30 August 2013 10:37, Minkyu Kang <mk7.kang@samsung.com> wrote:
> On 28/08/13 20:47, Tushar Behera wrote:
>> On 19 August 2013 11:30, Tushar Behera <tushar.behera@linaro.org> wrote:
>>> On 19 August 2013 10:01, Donghwa Lee <dh09.lee@samsung.com> wrote:
>>>> On 2013? 08? 19? 12:06, Tushar Behera wrote:
>>>>> On 19 August 2013 07:22, Donghwa Lee <dh09.lee@samsung.com> wrote:
>>>>>> On Fri, Aug 16, 2013 at 16:31, Ajay kumar wrote:
>>>>>>
>>>>>> On Thu, Aug 15, 2013 at 6:53 PM, Tushar Behera <tushar.behera@linaro.org>
>>>>>> wrote:
>>>>>>> On EXYNOS4210, there are three paths for display data to be processed,
>>>>>>> namely MIE, MDNIE and FIMD. On Origen board, FIMD display controller
>>>>>>> is used.
>>>>>>>
>>>>>>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>>>>>>> ---
>>>>>>> Changes for V2:
>>>>>>> * Updated review comments from Ajay Kumar, reusing the code from
>>>>>>> arch/arm/cpu/armv7/exynos/system.c.
>>>>>>>
>>>>>>>  board/samsung/origen/origen.c |    3 +++
>>>>>>>  1 file changed, 3 insertions(+)
>>>>>>>
>>>>>>> diff --git a/board/samsung/origen/origen.c b/board/samsung/origen/origen.c
>>>>>>> index 15f77ca..bb16699 100644
>>>>>>> --- a/board/samsung/origen/origen.c
>>>>>>> +++ b/board/samsung/origen/origen.c
>>>>>>> @@ -22,6 +22,9 @@ int board_init(void)
>>>>>>>         gpio2 = (struct exynos4_gpio_part2 *) EXYNOS4_GPIO_PART2_BASE;
>>>>>>>
>>>>>>>         gd->bd->bi_boot_params = (PHYS_SDRAM_1 + 0x100UL);
>>>>>>> +
>>>>>>> +       set_system_display_ctrl();
>>>>>>> +
>>>>>> Ok. You are trying to get the display up in the kernel,
>>>>>> without enabling the display in u-boot.
>>>>>> And, thats why you are making an explicit call here?
>>>>>>
>>>>> Yes, as of now, I don't want LCD support in u-boot, but I want to just
>>>>> enable the display path.
>>>>>
>>>>
>>>> If you don't need to LCD support in u-boot, which case do you need to enable the display path to FIMD?
>>>>
>>>
>>> This modification is essential for enabling LCD support in kernel.
>>> While working with DT kernel, we couldn't any suitable place in kernel
>>> where we can place this code. That is the reason why we thought of
>>> having this bit setup in u-boot.
>>>
>
> I understood your concept.
> but I feel, it's a workaround.
>
> you said.
> "
> I tried enabling CONFIG_LCD and related config options so that
> existing display path in u-boot is called. That somehow stalls the
> u-boot and I didn't want to pursue that much as calling this function
> fixes my issue.
> "
>
> Why don't you try to find the reason why stalls the u-boot.
>

I spent some time on fixing this while I was working on this patch,
but couldn't debug the issue within the available time. If I can find
sometime for this, I will surely look into fixing this.

We have already got display support merged with upstream kernel. After
applying this patch to u-boot, developers can get display up with
upstream stuff. That was the motivation for having this patch.

-- 
Tushar Behera