From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v1, 8/8] mpc85xx: introduce the kmp204x reference design support
Date: Mon, 19 Aug 2013 17:51:26 +0200 [thread overview]
Message-ID: <52123EFE.3040002@keymile.com> (raw)
In-Reply-To: <520AA8B0.8040006@freescale.com>
On 08/13/2013 11:44 PM, York Sun wrote:
> On 07/26/2013 03:02 AM, Valentin Longchamp wrote:
>> +
>> +phys_size_t initdram(int board_type)
>> +{
>> + phys_size_t dram_size = 0;
>> +
>> + puts("Initializing....");
>> +
>> + if (fsl_use_spd()) {
>> + puts("using SPD\n");
>> + dram_size = fsl_ddr_sdram();
>> + } else {
>> + puts("no SPD and fixed parameters\n");
>> + return dram_size;
>> + }
>
>
> How does the else clause work? You probably want to put an error or
> panic here if you don't have other way to initialize it.
>
OK I agree.
Valentin
prev parent reply other threads:[~2013-08-19 15:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 10:02 [U-Boot] [PATCH v1 0/8] Support for the kmp204x reference design Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 1/8] km-powerpc: move SYS_MALLOC_LEN out of keymile-common.h Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 2/8] km-powerpc: move CONFIG_FLASH_CFI_MTD to km83xx-common.h Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 3/8] KM: fix typo in default environment Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 4/8] mpc8xxx: set x2 DDR3 refresh rate if SPD config requires it Valentin Longchamp
2013-08-13 20:24 ` [U-Boot] [U-Boot, v1, " York Sun
2013-08-19 15:25 ` Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 5/8] fsl: do not define FSL_SRIO_PCIE_BOOT_MASTER for all P2041 systems Valentin Longchamp
2013-08-13 20:32 ` [U-Boot] [U-Boot, v1, " York Sun
2013-08-19 15:26 ` Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 6/8] net/fman: add a fm_enable_port function Valentin Longchamp
2013-08-13 20:38 ` [U-Boot] [U-Boot, v1, " York Sun
2013-08-19 15:28 ` Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 7/8] mtd/fsl_elbc: take NAND_ECC_SOFT_BCH config option into accout Valentin Longchamp
2013-08-13 20:54 ` Scott Wood
2013-08-19 15:34 ` Valentin Longchamp
2013-07-26 10:02 ` [U-Boot] [PATCH v1 8/8] mpc85xx: introduce the kmp204x reference design support Valentin Longchamp
2013-08-13 21:38 ` Scott Wood
2013-08-19 15:50 ` Valentin Longchamp
2013-08-20 0:48 ` Scott Wood
2013-08-20 1:02 ` York Sun
2013-08-20 18:20 ` Scott Wood
2013-08-20 18:21 ` Scott Wood
2013-08-20 19:40 ` York Sun
2013-08-20 19:47 ` Scott Wood
2013-08-20 19:57 ` York Sun
2013-08-20 20:03 ` Scott Wood
2013-08-20 20:26 ` York Sun
2013-08-20 23:24 ` [U-Boot] [RFC PATCH 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100 Scott Wood
2013-08-20 6:28 ` [U-Boot] [PATCH v1 8/8] mpc85xx: introduce the kmp204x reference design support Valentin Longchamp
2013-08-20 18:18 ` Scott Wood
2013-08-21 6:36 ` Valentin Longchamp
2013-08-21 23:11 ` Scott Wood
2013-08-13 21:44 ` [U-Boot] [U-Boot, v1, " York Sun
2013-08-19 15:51 ` Valentin Longchamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52123EFE.3040002@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox