From mboxrd@z Thu Jan  1 00:00:00 1970
From: Valentin Longchamp <valentin.longchamp@keymile.com>
Date: Mon, 19 Aug 2013 17:51:26 +0200
Subject: [U-Boot] [U-Boot, v1,
 8/8] mpc85xx: introduce the kmp204x reference design support
In-Reply-To: <520AA8B0.8040006@freescale.com>
References: <1374832955-4544-9-git-send-email-valentin.longchamp@keymile.com>
	<520AA8B0.8040006@freescale.com>
Message-ID: <52123EFE.3040002@keymile.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/13/2013 11:44 PM, York Sun wrote:
> On 07/26/2013 03:02 AM, Valentin Longchamp wrote:
>> +
>> +phys_size_t initdram(int board_type)
>> +{
>> +	phys_size_t dram_size = 0;
>> +
>> +	puts("Initializing....");
>> +
>> +	if (fsl_use_spd()) {
>> +		puts("using SPD\n");
>> +		dram_size = fsl_ddr_sdram();
>> +	} else {
>> +		puts("no SPD and fixed parameters\n");
>> +		return dram_size;
>> +	}
> 
> 
> How does the else clause work? You probably want to put an error or
> panic here if you don't have other way to initialize it.
> 

OK I agree.

Valentin