public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] fsl_i2c: add workaround for the erratum I2C A004447
Date: Tue, 20 Aug 2013 11:20:51 +0200	[thread overview]
Message-ID: <521334F3.4050700@denx.de> (raw)
In-Reply-To: <1376637037-17839-2-git-send-email-Chunhe.Lan@freescale.com>

Hello Chunhe,

Am 16.08.2013 09:10, schrieb Chunhe Lan:
> This workaround is for the erratum I2C A004447. Device reference
> manual provides a scheme that allows the I2C master controller
> to generate nine SCL pulses, which enable an I2C slave device
> that held SDA low to release SDA. However, due to this erratum,
> this scheme no longer works. In addition, when I2C is used as
> a source of the PBL, the state machine is not able to recover.
>
> At the same time, delete the reduplicative definition of SVR_VER
> and SVR_REV. The SVR_REV is the low 8 bits rather than the low 16
> bits of svr. And we use the CONFIG_SYS_FSL_A004447_SVR_REV macro
> instead of hard-code value 0x10, 0x11 and 0x20.
>
> The CONFIG_SYS_FSL_A004447_SVR_REV = 0x00 represents that one
> version of platform has this I2C errata. So enable this errata
> by IS_SVR_REV(svr, maj, min) function.
>
> Signed-off-by: Zhao Chenhui<chenhui.zhao@freescale.com>
> Signed-off-by: Chunhe Lan<Chunhe.Lan@freescale.com>
> Cc: Scott Wood<scottwood@freescale.com>
> Cc: Heiko Schocher<hs@denx.de>
> ---
> Changes for v2:
> 	- Caller directly uses CONFIG_SYS_FSL_A004447_SVR_REV
> 	  to judge whether SVR_REV is less than or equal
> 	  CONFIG_SYS_FSL_A004447_SVR_REV
> 	- SVR_REV is the low 8 bits rather than the low 16
> 	  bits of svr
> Changes for v3:
> 	- Rework codes for the newest mainline
>
>   arch/powerpc/cpu/mpc85xx/cmd_errata.c     |    5 +++++
>   arch/powerpc/include/asm/config_mpc85xx.h |   16 ++++++++++++++++
>   arch/powerpc/include/asm/fsl_i2c.h        |    1 +
>   arch/powerpc/include/asm/processor.h      |    5 +----
>   drivers/i2c/fsl_i2c.c                     |   14 +++++++++++---
>   5 files changed, 34 insertions(+), 7 deletions(-)

Applied to u-boot-i2c.git, thanks.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2013-08-20  9:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-16  7:10 [U-Boot] [PATCH v3 1/2] fsl_i2c: generate nine pulses on SCL if the I2C bus is hung Chunhe Lan
2013-08-16  7:10 ` [U-Boot] [PATCH v3 2/2] fsl_i2c: add workaround for the erratum I2C A004447 Chunhe Lan
2013-08-20  9:20   ` Heiko Schocher [this message]
2013-08-20  9:20 ` [U-Boot] [PATCH v3 1/2] fsl_i2c: generate nine pulses on SCL if the I2C bus is hung Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521334F3.4050700@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox