From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fec_mxc: set ethaddr if fuses burned and not previously set
Date: Wed, 21 Aug 2013 13:19:27 +0200 [thread overview]
Message-ID: <5214A23F.2070108@denx.de> (raw)
In-Reply-To: <1375465020-20058-1-git-send-email-eric.nelson@boundarydevices.com>
Hi Eric,
On 02/08/2013 19:37, Eric Nelson wrote:
> Without this change, the following message is generated:
> Warning: FEC using MAC address from net device
>
> See doc/README.enetaddr for details.
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> drivers/net/fec_mxc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index e14a359..886be9c 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -980,6 +980,8 @@ static int fec_probe(bd_t *bd, int dev_id, uint32_t base_addr,
> if (fec_get_hwaddr(edev, dev_id, ethaddr) == 0) {
> debug("got MAC%d address from fuse: %pM\n", dev_id, ethaddr);
> memcpy(edev->enetaddr, ethaddr, 6);
> + if (!getenv("ethaddr"))
> + eth_setenv_enetaddr("ethaddr",mac);
^--
of course, this should be ethaddr and not mac. I fixed it myself.
Best regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-08-21 11:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 17:37 [U-Boot] [PATCH] fec_mxc: set ethaddr if fuses burned and not previously set Eric Nelson
2013-08-21 10:42 ` Stefano Babic
2013-08-21 11:19 ` Stefano Babic [this message]
2013-08-21 13:28 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214A23F.2070108@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox