From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] gpio: atmel: remove the at91_pio definition
Date: Wed, 21 Aug 2013 17:10:14 +0200 [thread overview]
Message-ID: <5214D856.6050405@gmail.com> (raw)
In-Reply-To: <1376375912-13835-3-git-send-email-voice.shen@atmel.com>
On 08/13/2013 08:38 AM, Bo Shen wrote:
> the at91_pio definition is no longer needed, so remove it
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> arch/arm/include/asm/arch-at91/at91_pio.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-at91/at91_pio.h b/arch/arm/include/asm/arch-at91/at91_pio.h
> index 676f024..ba61542 100644
> --- a/arch/arm/include/asm/arch-at91/at91_pio.h
> +++ b/arch/arm/include/asm/arch-at91/at91_pio.h
> @@ -109,21 +109,6 @@ typedef struct at91_port {
> #endif
> } at91_port_t;
>
> -typedef union at91_pio {
> - struct {
> - at91_port_t pioa;
> - at91_port_t piob;
> - at91_port_t pioc;
> - #if (ATMEL_PIO_PORTS > 3)
> - at91_port_t piod;
> - #endif
> - #if (ATMEL_PIO_PORTS > 4)
> - at91_port_t pioe;
> - #endif
> - } ;
> - at91_port_t port[ATMEL_PIO_PORTS];
> -} at91_pio_t;
> -
NAK, this breaks at least 7 boards:
14: gpio: atmel: remove the at91_pio definition
arm: + at91sam9263ek_dataflash_cs0 eb_cpux9k2 at91rm9200ek_ram
cpuat91 vl_ma2sc vl_ma2sc_ram cpuat91_ram
We need to have this typedef while we have the new API and change the
users of this struct to the new API after introducing.
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2013-08-21 15:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 6:38 [U-Boot] [PATCH 0/4] gpio: atmel: fix code to use pointer for pio port Bo Shen
2013-08-13 6:38 ` [U-Boot] [PATCH 1/4] " Bo Shen
2013-08-21 15:08 ` Andreas Bießmann
2013-08-22 3:15 ` Bo Shen
2013-08-22 6:26 ` Andreas Bießmann
2013-08-22 7:03 ` Bo Shen
2013-08-22 7:24 ` [U-Boot] [PATCH v2] " Bo Shen
2013-08-22 15:01 ` [U-Boot] [U-Boot,v2] " Andreas Bießmann
2013-08-13 6:38 ` [U-Boot] [PATCH 2/4] gpio: atmel: remove the at91_pio definition Bo Shen
2013-08-21 15:10 ` Andreas Bießmann [this message]
2013-08-13 6:38 ` [U-Boot] [PATCH 3/4] gpio: atmel: add gpio common API support Bo Shen
2013-08-21 15:14 ` Andreas Bießmann
2013-08-22 3:21 ` Bo Shen
2013-08-22 6:34 ` Andreas Bießmann
2013-08-22 7:06 ` Bo Shen
2013-08-22 15:01 ` [U-Boot] [U-Boot,3/4] " Andreas Bießmann
2013-08-13 6:38 ` [U-Boot] [PATCH 4/4] gpio: atmel: add copyright and remove error header info Bo Shen
2013-08-21 15:17 ` Andreas Bießmann
2013-08-21 17:20 ` Jens Scharsig
2013-08-21 17:20 ` Jens Scharsig
2013-08-22 15:01 ` [U-Boot] [U-Boot,4/4] " Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5214D856.6050405@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox