From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Thu, 22 Aug 2013 15:03:39 +0800 Subject: [U-Boot] [PATCH 1/4] gpio: atmel: fix code to use pointer for pio port In-Reply-To: <5215AF19.6020305@googlemail.com> References: <1376375912-13835-1-git-send-email-voice.shen@atmel.com> <1376375912-13835-2-git-send-email-voice.shen@atmel.com> <5214D7DD.2060205@gmail.com> <52158248.9090801@atmel.com> <5215AF19.6020305@googlemail.com> Message-ID: <5215B7CB.5080000@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andreas, On 8/22/2013 14:26, Andreas Bie?mann wrote: >>> Please adopt all places in this file with mentioned changes and tell me >>> >>your opinion about erroneous return value. >> > >> >For the erroneous return value, actually we never check it (consider it >> >always successfully). So, I think now we just keep it as is, and >> >consider a proper method after this patch set. Would it be OK? > I'm fine with that. If no one else complains I'll try to push this into > -rc2 for this release. The API change would then come for next release, > am I right? I will prepare the v2 for this patch, after test OK and compile testing for all Atmel EK board, I will send out the patch. If this series can go into this release will be better. As if without the common GPIO API patch applied, we can not use gpio command, software i2c support and etc. > Best regards > > Andreas Bie?mann Best Regards, Bo Shen