From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Przywara <andre.przywara@linaro.org>
Date: Tue, 27 Aug 2013 11:51:15 +0200
Subject: [U-Boot] [PATCH v4 2/8] ARM: add secure monitor handler to
 switch to non-secure state
In-Reply-To: <20130827092325.85B6.AA925319@jp.panasonic.com>
References: <1376060592-10824-1-git-send-email-andre.przywara@linaro.org>
	<1376060592-10824-3-git-send-email-andre.przywara@linaro.org>
	<20130827092325.85B6.AA925319@jp.panasonic.com>
Message-ID: <521C7693.5050506@linaro.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 08/27/2013 02:23 AM, Masahiro Yamada wrote:
> Hello Andre,
>
>> +/* the vector table for secure state */
>> +_monitor_vectors:
>> +	.word 0	/* reset */
>> +	.word 0 /* undef */
>> +	adr pc, _secure_monitor
>> +	.word 0
>> +	.word 0
>> +	.word 0
>> +	.word 0
>> +	.word 0
>> +	.word 0	/* pad */
>
> Could you explain why the last line is needed?

I guess I cannot explain because it's probably not needed ;-)
I copied this from somewhere else and accidentally this padding somehow 
sneaked in (from the actual addresses array, where the start vector was 
missing and thus the array ended at 7 * 4 bytes)

Do we need another version or is a follow-up patch sufficient?
I'd like to avoid another review round for the sake of the reviewers.

Thanks for spotting this,
Andre.