public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] SPL boot on iMX6
Date: Tue, 27 Aug 2013 14:53:59 +0200	[thread overview]
Message-ID: <521CA167.6010705@denx.de> (raw)
In-Reply-To: <521B64E9.4090203@boundarydevices.com>

Hi Eric,

On 26/08/2013 16:23, Eric Nelson wrote:
> 
> Functionally, we still need table(s) for any image which supports either
> variant so the proper set of pads are configured.
> 
> See this for an example
>     http://lists.denx.de/pipermail/u-boot/2012-October/136394.html
> 

Ok - what I meant is to avoid to convert the static definitions (enums)
in the header in a sort of tables. I agree that using tables in the
board code is needed and makes the code more readable using
imx_iomux_v3_setup_multiple_pads().

> The construct used in that patch set was to define FOR_DL_SOLO,
> then include the pad file.
>     #ifdef CONFIG_MX6Q
>     #include "pads.h"
>     #endif
>     #if defined(CONFIG_MX6DL) || defined(CONFIG_MX6S)
>     #define FOR_DL_SOLO
>     #include "pads.h"
>     #endif
> 
> Troy's implementation used a naming convention of mx6q_X
> and mx6dl_solo_X such that a board supporting both would have
> variables
> 
>     static iomux_v3_cfg_t mx6q_usdhc3_pads = ...
> 
> followed by
> 
>     static iomux_v3_cfg_t mx6dl_solo_usdhc3_pads = ...
> 

ok, this is a solution. Let's wait for next Tapani's patch and when we
start the discussion ;-)

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-08-27 12:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26  7:17 [U-Boot] SPL boot on iMX6 Tapani Utriainen
2013-08-26  7:42 ` Stefano Babic
2013-08-26 11:12   ` Tapani
2013-08-26 13:33     ` Stefano Babic
2013-08-26 14:23       ` Eric Nelson
2013-08-27 12:53         ` Stefano Babic [this message]
2013-08-27  4:07       ` Tapani Utriainen
2013-08-27 13:00         ` Stefano Babic
2013-08-27 15:00         ` Eric Nelson
2013-08-26 13:28 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521CA167.6010705@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox